Pending

User tests: Successful: Unsuccessful:

avatar stell
stell
30 Jan 2024

If you have complex, database-heavy extensions that have been in existence for many years, it often happens that SQL errors occur in the installation routine during updates at long intervals for various reasons.
At present, only the error is displayed, but not in which update file it occurred. If there are 50 such files, the search for the error can be unnecessarily lengthy.

Summary of Changes

Updated one line to be able to name the responsible file.

Actual result BEFORE applying this Pull Request

Example:
Installer: :Install: Error SQL Duplicate column name 'uid'

Expected result AFTER applying this Pull Request

Example:
Installer: :Install: Error SQL Duplicate column name 'uid' (4.3.3.sql)

avatar stell stell - open - 30 Jan 2024
avatar stell stell - change - 30 Jan 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 30 Jan 2024
Category Libraries
avatar ceford
ceford - comment - 26 Feb 2024

Could not see an easy way for me to live test this but I did check the code, applied the patch and installed an extension. Pass!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42732.

avatar ceford ceford - test_item - 26 Feb 2024 - Tested successfully
avatar ceford
ceford - comment - 26 Feb 2024

I have tested this item ✅ successfully on 3915cb1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42732.

avatar exlemor
exlemor - comment - 21 Apr 2024

Hi @stell, I can't see/understand/figure out how to test this based on what you wrote (sorry), if you can provide a file or a specific way to test it, i'll gladly test it.

avatar HLeithner
HLeithner - comment - 24 Apr 2024

It's a feature shouldn't be merged in to 4.4

avatar HLeithner HLeithner - change - 24 Apr 2024
Title
Update Installer.php
[4.4] Update Installer.php
avatar HLeithner HLeithner - edited - 24 Apr 2024
avatar HLeithner
HLeithner - comment - 15 Nov 2024

This pull request has been automatically rebased to 5.3-dev.

Add a Comment

Login with GitHub to post a comment