[#42729] - [5.1] Deprecating RouterLegacy class
- Fixed in Code Base
- 2 Mar 2024
- Medium
- Build: 5.1-dev
- # 42729
- Diff
- Hackwar:5.1-router-legacy
User tests: Successful: Unsuccessful:
Summary of Changes
Since Joomla 3.3 we have the class-based routers and it is time to remove the support for the old function-based routers. This PR deprecates the legacy support class for the old routers.
Testing Instructions
Codereview
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
wilsonge
- | Labels |
Added:
Feature
PR-5.1-dev
|
||
@brianteeman if something is deprecated in a major version, it can be removed 2 major versions later.
@brianteeman if something is deprecated in a major version, it can be removed 2 major versions later.
Which is why ~I asked two weeks ago when you submitted this PR saying removal in 6.0
And the production department can deviate from that rule if they deem it necessary. I would have removed it earlier, but the department voted against this. So 7.0 it is.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-03-02 19:43:44 |
| Closed_By | ⇒ | bembelimen | |
| Labels |
Added:
b/c break
|
||
Thx
What is the policy now for when something can be removed?