Feature b/c break PR-5.1-dev Pending

User tests: Successful: Unsuccessful:

avatar Hackwar
Hackwar
30 Jan 2024

Summary of Changes

Since Joomla 3.3 we have the class-based routers and it is time to remove the support for the old function-based routers. This PR deprecates the legacy support class for the old routers.

Testing Instructions

Codereview

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar Hackwar Hackwar - open - 30 Jan 2024
avatar Hackwar Hackwar - change - 30 Jan 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 30 Jan 2024
Category Libraries
avatar brianteeman
brianteeman - comment - 30 Jan 2024

What is the policy now for when something can be removed?

avatar wilsonge wilsonge - change - 5 Feb 2024
Labels Added: Feature PR-5.1-dev
avatar Hackwar
Hackwar - comment - 15 Feb 2024

@brianteeman if something is deprecated in a major version, it can be removed 2 major versions later.

avatar brianteeman
brianteeman - comment - 15 Feb 2024

@brianteeman if something is deprecated in a major version, it can be removed 2 major versions later.

Which is why ~I asked two weeks ago when you submitted this PR saying removal in 6.0

avatar Hackwar
Hackwar - comment - 15 Feb 2024

And the production department can deviate from that rule if they deem it necessary. I would have removed it earlier, but the department voted against this. So 7.0 it is.

avatar bembelimen bembelimen - merge - 2 Mar 2024
avatar bembelimen bembelimen - change - 2 Mar 2024
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2024-03-02 19:43:44
Closed_By bembelimen
Labels Added: b/c break
avatar bembelimen bembelimen - close - 2 Mar 2024
avatar bembelimen
bembelimen - comment - 2 Mar 2024

Thx

Add a Comment

Login with GitHub to post a comment