Feeling Lucky
PR-4.4-dev
[#42722] - [4.4] Fix message for banner tracks delete
- Closed
- 31 Jan 2024
- Medium
- Build: 4.4-dev
- # 42722
- Diff
- chmst:banner-tracks-delete-message
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #42700 .
Summary of Changes
The issue contains two parts.
- A wrong message is displayed, it shows the number of existing tracks as deleted, not the deleted tracks
- If the filter is not set properly and if there are tracks to non existing banners and categories, these tracks never are deleted.
This PR is for 1)
The number of deleted rows, not the total amount of rows is displayes
Testing Instructions
You must have tracks in #__banner_tracks.
Delete tracks and see which number is returned
Actual result BEFORE applying this Pull Request
See the issue #42700
It says that the whole number of existing tracks is deleted
Expected result AFTER applying this Pull Request
Only the number of affectedRows is displayed
Link to documentations
No documentation, it'a bug
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_banners Language & Strings |
| Labels |
Added:
Language Change
PR-4.4-dev
|
||
| Category | Administration com_banners Language & Strings | ⇒ | Administration com_banners |
| Labels |
Removed:
Language Change
|
||
laoneo
- comment
- 31 Jan 2024
I do not agree with this change as all the delete functions in models are returning a boolean and not the amount of deleted records. Either change it all or leave it as is.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-01-31 23:17:06 |
| Closed_By | ⇒ | chmst |
Changed the access control for deleting banner tracks
Deleting banner tracks does not delete banners or categories, it changes the statistic data in banners. The check for core.delete is replaced by core.edit
What is still open question: what to do with orphaned tracks? They remain untouched in the database.