[#42719] - [5.1] Add main region on error page
- Fixed in Code Base
- 1 Feb 2024
- Medium
- Build: 5.1-dev
- # 42719
- Diff
- Razzo1987:5.1/error/main
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Pull Request related to #42652 .
Read comment #42652 (comment)
Now whe are changing the semantic.
Summary of Changes
Add <main> on error.php template page.
Also when there is a module in the error-* position
Testing Instructions
Case 1: Go on page error and see the source
Case 2: Add module to error-403 or error-404 position. Go on page error and see the source
Actual result BEFORE applying this Pull Request
Case 1 and Case 2: There is no <main> element
Expected result AFTER applying this Pull Request
Case 1: Now the error message is inside the <main> element
Case 2: Now the module is inside the <main> element
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
Thanks to @brianteeman and @richard67 for the brainstorming ;)
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Templates (site) |
You should also add the
mainregion for the regular use
@Razzo1987 Yes, Brian is right, it should also be added in the else branch like I wrote in my comment which you referred to:
I think the
<main>should go to line 163 of the file changed by this PR, just after the<jdoc:include type="message" />, and it should be closed in line 177 (or 178 after adding the opening tag) just after the</blockquote>and before the</div>.
Here in 5.1-dev the line numbers stilll fit to my comment.
| Title |
|
||||||
| Labels |
Added:
Feature
Updates Requested
PR-5.1-dev
|
||
Correct, thanks!
@Razzo1987 Now it needs to adapt the testing instructions so that both cases are checked, with and without any module on an error-403 or error-404 position.
I have tested this item ✅ successfully on c6d4534
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42719.
I have tested this item ✅ successfully on c6d4534
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42719.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42719.
| Status | Ready to Commit | ⇒ | Pending |
| Status | Pending | ⇒ | Ready to Commit |
| Title |
|
||||||
| Title |
|
||||||
| Labels |
Added:
RTC
Removed: Updates Requested |
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-02-01 18:53:58 |
| Closed_By | ⇒ | LadySolveig |
Thank you @Razzo1987 and also for testing to @brianteeman and @viocassel
You should also add the
mainregion for the regular use