RTC PR-5.1-dev Pending

User tests: Successful: Unsuccessful:

avatar laoneo
laoneo
27 Jan 2024

Summary of Changes

To get away from the CMSObject class we need a step by step process in the getItem function of the admin model. Alternative to #42714 which makes the CMSObject a stdClass and changes the return type to it. It is a more lightweight solution as no new deprecated flag is introduced. It has basically the same effect as when we change the flag in 6.0.

Testing Instructions

Create an article in the back end. With as many content plugins as possible.

Actual result BEFORE applying this Pull Request

All works.

Expected result AFTER applying this Pull Request

All works.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org: joomla/Manual#232

  • No documentation changes for manual.joomla.org needed

avatar laoneo laoneo - open - 27 Jan 2024
avatar laoneo laoneo - change - 27 Jan 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 27 Jan 2024
Category Administration com_installer Libraries
avatar laoneo laoneo - change - 29 Jan 2024
Labels Added: PR-5.1-dev
avatar laoneo laoneo - change - 31 Jan 2024
Title
Change the getItem return type to stdClass abd make the CMSObject inherit it
Change the getItem return type to stdClass and make the CMSObject inherit it
avatar laoneo laoneo - edited - 31 Jan 2024
avatar crommie crommie - test_item - 24 Feb 2024 - Tested successfully
avatar crommie
crommie - comment - 24 Feb 2024

I have tested this item ✅ successfully on 080cca9

I've created an article with a number of custom fields and schema stuff. No difference before / after patch so I guess it works.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42717.

avatar viocassel viocassel - test_item - 24 Feb 2024 - Tested successfully
avatar viocassel
viocassel - comment - 24 Feb 2024

I have tested this item ✅ successfully on 080cca9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42717.

avatar richard67 richard67 - change - 24 Feb 2024
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 24 Feb 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42717.

avatar LadySolveig LadySolveig - change - 27 Feb 2024
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2024-02-27 10:45:34
Closed_By LadySolveig
Labels Added: RTC
avatar LadySolveig LadySolveig - close - 27 Feb 2024
avatar LadySolveig LadySolveig - merge - 27 Feb 2024
avatar LadySolveig
LadySolveig - comment - 27 Feb 2024

Thank you @laoneo and also for testing @crommie and @viocassel

avatar laoneo laoneo - change - 5 Mar 2024
The description was changed
avatar laoneo laoneo - edited - 5 Mar 2024
avatar laoneo laoneo - change - 5 Mar 2024
The description was changed
avatar laoneo laoneo - edited - 5 Mar 2024

Add a Comment

Login with GitHub to post a comment