User tests: Successful: Unsuccessful:
Pull Request for Issue ##42181 .
Adds a check to see if the symlink function is available in php before proceeding with the cli script to create a public folder and provide an informative error message
php .\cli\joomla.php site:create-public-folder
if the function is not available
php cli/joomla.php site:create-public-folder
Create a public folder
======================
Please enter the absolute path to the public folder:
> /home/webmaven/public_html/pubtmp6
In PublicFolderGeneratorHelper.php line 199:
Call to undefined function Joomla\CMS\Helper\symlink()
if the function is not available
php8 cli/joomla.php site:create-public-folder
Create a public folder
======================
Please enter the absolute path to the public folder:
> /home/brian/public_html/ttt66
[ERROR] symlink() function is not enabled on the server. Please enable it to proceed
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
Status | New | ⇒ | Pending |
Category | ⇒ | Libraries |
Why not?
Labels |
Added:
PR-5.0-dev
|
because we use 100ts of php functions and can't check everyone and if you can't create symlink in the cli something is broken with your isp
but what every don't want to be a stopper here do what you like
Then we might as well remove all the other checks for php functions that already exist. This cli command relies 100% on the symlink function and it is VERY common that this is disabled.
symlink disabled in cli, wow, sorry I don't think we can and should check if every function is available.
On a lot of shared hosting symlinks are disabled in php.ini files - there's quite a lot of places we already check in core this this stuff. It seems like a very sensible check to me.
Labels |
Added:
PBF
bug
|
I have tested this item ✅ successfully on d0b138d
I have tested this item ✅ successfully on d0b138d
Status | Pending | ⇒ | Ready to Commit |
Labels |
Added:
RTC
|
Thanks!
I did - enabled automerge and updated the branch (so when tests pass after that it gets merged). But someone disabled it without comment so ?
Yeah, it was me, it was targeting the 5.0 branch and I just saw it on my mobile phone...that's why I disabled it, but thanksfully Martina rebased.
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-03-04 11:00:41 |
Closed_By | ⇒ | bembelimen | |
Labels |
Added:
PR-5.1-dev
Removed: PR-5.0-dev |
Thx
symlink disabled in cli, wow, sorry I don't think we can and should check if every function is available.