[#42703] - [5.2] Implement Schema.org support for Menu Items
- Closed
- 30 Apr 2024
- Medium
- Build: 5.1-dev
- # 42703
- Diff
- krileon:menu-item-schemaorg
User tests: Successful: Unsuccessful:
Summary of Changes
Implements same Article and Contact Schema.org parameters and parsing into JSON-LD for Menu Items. This allows extensions and other custom pages to leverage Schema.org JSON-LD without needing any additional development.
The JSON-LD will be appended in the following order: Base -> Webpage -> Menu -> Content
Menu Schema can be globally turned off should anyone not want it. Default enabled, but same as articles it requires the schemaorg plugin to be saved at least once to establish the base.
Testing Instructions
- Edit, publish, toggle on Menus parameter, and save "System - Schema.org" plugin
- Create or edit a new menu item
- Configure and save data under the Schema tab as you would with an Article
- Navigate to that menu item on frontend
- Press F12 to open your browsers developer tools
- Review the
<head>to make sure your JSON-LD Schema data is present
I've tested this on the following component frontend views: com_content, com_users, com_contact, and com_wrapper
Additional component tests would be appreciated (e.g. a variant of 3rd party extensions would be great).
Actual result BEFORE applying this Pull Request
No Schema tab in menu edit/create
Expected result AFTER applying this Pull Request
Schema tab in menu edit/create
Link to documentations
Please select:
- Documentation link for docs.joomla.org:
- No documentation changes for docs.joomla.org needed
- Pull Request link for manual.joomla.org:
- No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_menus Language & Strings Front End Plugins |
| Labels |
Added:
Language Change
PR-5.1-dev
|
||
I have tested this item ✅ successfully on 8081f3e
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42703.
I have tested this item ✅ successfully on 8081f3e
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42703.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42703.
| Labels |
Added:
RTC
|
||
@krileon are you in Mattermost and could you contact me or @LadySolveig ? We really like your contributions and would like to discuss some bigger pictures with you.
I'm not in Mattermost. Bigger pictures as in about this PR? Feel free to discuss away in this PR I'm fine with full public transparency.
This pull request has been automatically rebased to 5.2-dev.
| Title |
|
||||||
This PR does not work in the way it's intended.
In general the schema.org information should come from the extension, not from the menu, as schema.org is content related. But beside that, for many menu types we have no schema (so developer for extension would need to ship that, which then can be implemented directly in the extension) or it would worsen the current solution (e.g. Category view of article).
As written above, there needs to be a bigger picture implemented. Which covers all the cases.
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-04-30 12:23:44 |
| Closed_By | ⇒ | bembelimen | |
| Labels |
Added:
Feature
PR-5.2-dev
Removed: PR-5.1-dev |
||
This PR does not work in the way it's intended.
The PR works exactly as intended. Adds Schema support to menu items. Allowing for Schema in any extension and any menu item without any additional implementation from developers of extensions. It's easy for end users to use as it's located exactly where their content links are.
In general the schema.org information should come from the extension, not from the menu, as schema.org is content related.
Menu items link to content. So they are directly related to the content. This completely shows a misunderstanding of menu items and their significance on your part. With this weird argument you're suggesting menu items shouldn't have metadata parameters either.
But beside that, for many menu types we have no schema (so developer for extension would need to ship that, which then can be implemented directly in the extension) or it would worsen the current solution (e.g. Category view of article).
Then don't enable it for those menu items? It does absolutely nothing on menu items it's not enabled on. I fail to see the issue here. I specifically put a comment block to note that in the code. It can't worsen category view as It extends the existing Schema and again does nothing if not used on that menu item.
As written above, there needs to be a bigger picture implemented. Which covers all the cases.
This quite literally covers all cases. I asked for feedback. You simply repeated what you said earlier. "Bigger picture" isn't feedback, lol.
I assume again this was a closed doors discussion instead of publicly as I asked for. If you didn't like my code or how it was implemented and had suggestions for improvements or a different way to do it then that'd of been fine.
Alright well I believe I am officially done with ever contributing again and it has nothing to do with a PR being rejected, but with how this project is being managed and a complete lack of communication. Best of luck.
quick response - I can now see schemaorg data on components that are not com_content