Segmentation fault when debugging language if there is an overriden string key starting with "_"
Just a question. Where can I get this issue template?
Just create a string override in Language Manager=>Overrides
Enter directly in the fields
_CONSTANT
and
some text
Save, then save and close
You can edit an existing xx-XX.override.ini file to also test
As you say, there is no reason to donĀ“t allow keys starting with _ (as far as I know), but neither to allow it. (I got that error because I was making test and wanted to disable that entry easy) I think is more robust to simply catch that errors instead of modifying the regex
The issue is that any error in an override.ini is not catched at all now...
Title |
|
||||||
Status | New | ⇒ | Confirmed |
Title |
|
||||||
Labels |
Added:
?
|
Status | Confirmed | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-11-12 13:45:09 |
Closed_By | ⇒ | brianteeman |
Title |
|
I can no longer replicate this. I assume it has been resolved elsewhere - if that is not the case and yu can provide new instructions to replicate the issue it can always be re-opened.
oops, debug overrides is now fixed
I confirm we get
( ! ) Fatal error: Maximum function nesting level of '100' reached, aborting! in ROOT/libraries/joomla/language/language.php on line 1164
Such a string starting with an underscore in a "normal" ini will just trigger a parsing error in the debug.
To solve that error, as there is no reason to prevent a constant to start by an underscore, we just have to do this, i.e. add the underscore in the regex:
But it will not solve in fact ANY parsing error in an xx-XX.override.ini file.
We always, instead of the debug, get the Fatal error there for any error (like a missing ")
It would be good to solve both issues at the same time, or I can make a PR for the underscore issue only for the moment.
What do you think?