Feature RTC Language Change PBF PR-5.1-dev Pending

User tests: Successful: Unsuccessful:

avatar bembelimen
bembelimen
22 Jan 2024

Pull Request for Issue # .

Summary of Changes

This PR adds a "Generic" schema.org type which offers a JSON field to add any schema.org JSON-LD.

Testing Instructions

  • Apply the PR
  • Go to an article (or create one)
  • Setup the schema.org plugin once
  • Select "Generic" as Schema Type
    grafik
  • Add any valid JSON-LD string to the JSON field
  • Save
  • Open article in frontend
  • Check browser source code
  • Check page with https://search.google.com/test/rich-results

Actual result BEFORE applying this Pull Request

No Generic type available

Expected result AFTER applying this Pull Request

Generic type available

avatar bembelimen bembelimen - open - 22 Jan 2024
avatar bembelimen bembelimen - change - 22 Jan 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 22 Jan 2024
Category SQL Administration com_admin Postgresql Language & Strings Installation Front End Plugins
avatar bembelimen bembelimen - change - 22 Jan 2024
Labels Added: Language Change PR-5.1-dev
avatar brianteeman
brianteeman - comment - 23 Jan 2024

Please update libraries\src\Extension\ExtensionHelper

avatar brianteeman
brianteeman - comment - 23 Jan 2024

I think a better name for this plugin would be Custom and not Generic

Generic means it is something suitable for everything
Custom means it is something unique and specific

But its a close call and probably something lost in translation anyway

avatar bembelimen
bembelimen - comment - 23 Jan 2024

I think a better name for this plugin would be Custom and not Generic

Generic means it is something suitable for everything Custom means it is something unique and specific

But its a close call and probably something lost in translation anyway

As I'm not native, I can't judge, so will change it to "custom" in the next days.

avatar joomla-cms-bot joomla-cms-bot - change - 23 Jan 2024
Category SQL Administration com_admin Postgresql Language & Strings Installation Front End Plugins SQL Administration com_admin Postgresql Language & Strings Installation Libraries Front End Plugins
avatar brianteeman
brianteeman - comment - 23 Jan 2024

Trying to test this but everything /I have tried to paste gives an error

For example I took this json from another page - validated at google and then tried to paste it.

Am I doing something wrong?


{
    "@context": "https://schema.org",
    "@graph": [
        {
            "@type": "Organization",
            "@id": "https://j5.test/#/schema/Organization/base",
            "name": "Joomla CMS Test",
            "url": "https://j5.test/"
        },
        {
            "@type": "WebSite",
            "@id": "https://j5.test/#/schema/WebSite/base",
            "url": "https://j5.test/",
            "name": "Joomla CMS Test",
            "publisher": {
                "@id": "https://j5.test/#/schema/Organization/base"
            },
            "potentialAction": {
                "@type": "SearchAction",
                "target": "https://j5.test/search?q={search_term_string}",
                "query-input": "required name=search_term_string"
            }
        },
        {
            "@type": "WebPage",
            "@id": "https://j5.test/#/schema/WebPage/base",
            "url": "https://j5.test/typography",
            "name": "Typography",
            "isPartOf": {
                "@id": "https://j5.test/#/schema/WebSite/base"
            },
            "about": {
                "@id": "https://j5.test/#/schema/Organization/base"
            },
            "inLanguage": "en-GB"
        },
        {
            "@type": "Article",
            "@id": "https://j5.test/#/schema/com_content/article/122",
            "name": "Typography",
            "headline": "Typography",
            "inLanguage": "en-GB",
            "isPartOf": {
                "@id": "https://j5.test/#/schema/WebPage/base"
            }
        }
    ]
}
avatar bembelimen
bembelimen - comment - 24 Jan 2024

The schema is only for the item, not the full website, so your JSON could look like:

{
    "@context": "https://schema.org",
    "@type": "Article",
    "@id": "https://j5.test/#/schema/com_content/article/122",
    "name": "Typography",
    "headline": "Typography",
    "inLanguage": "en-GB",
    "isPartOf": {
        "@id": "https://j5.test/#/schema/WebPage/base"
    }
}
avatar brianteeman brianteeman - test_item - 24 Jan 2024 - Tested successfully
avatar brianteeman
brianteeman - comment - 24 Jan 2024

I have tested this item ✅ successfully on 13737cb


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42699.

avatar brianteeman
brianteeman - comment - 24 Jan 2024

The schema is only for the item, not the full website, so your JSON could look like:

Thanks - all tested and working as far as i can tell

avatar chmst chmst - test_item - 24 Jan 2024 - Tested successfully
avatar chmst
chmst - comment - 24 Jan 2024

I have tested this item ✅ successfully on 13737cb


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42699.

avatar Quy
Quy - comment - 24 Jan 2024

Sort option in alpha order or ok to be at the end?

42699

avatar bembelimen
bembelimen - comment - 25 Jan 2024

Sort option in alpha order or ok to be at the end?

42699

Sorting is by plugin ordering, not really possible to have it alphabetical...

avatar bembelimen
bembelimen - comment - 5 Feb 2024

Thanks @LadySolveig

avatar crommie crommie - test_item - 24 Feb 2024 - Tested unsuccessfully
avatar crommie
crommie - comment - 24 Feb 2024

I have tested this item ? unsuccessfully on 53793d0

No generic schema type available after applying patch. Maybe I'm just not good at following instructions?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42699.

avatar hl-dev-DE hl-dev-DE - test_item - 24 Feb 2024 - Tested successfully
avatar hl-dev-DE
hl-dev-DE - comment - 24 Feb 2024

I have tested this item ✅ successfully on 53793d0


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42699.

avatar LadySolveig LadySolveig - change - 24 Feb 2024
Labels Added: Feature PBF
avatar crommie crommie - test_item - 24 Feb 2024 - Tested successfully
avatar crommie
crommie - comment - 24 Feb 2024

I have tested this item ✅ successfully on 9182a05

After I installed 5.1.0 beta 1 + PR 42699 package, everything works as expected.

I activated the plugin, opened an article, selected Custom (no longer "generic") and pasted the above valid JSON code.
No errors, everything fine.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42699.

avatar bembelimen bembelimen - change - 24 Feb 2024
Status Pending Ready to Commit
avatar bembelimen
bembelimen - comment - 24 Feb 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42699.

avatar richard67
richard67 - comment - 24 Feb 2024

@bembelimen The update SQL scripts need to be renamed from "5.1.0-2024-01-18.sql" to something newer than "5.1.0-2024-02-10.sql", which is the latest update SQL at the moment in the 5.1-dev branch, otherwise they will not run when updating from 5.1.0-alpha4 to beta1. I suggest to use "5.1.0-2024-02-25.sql", as "5.1.0-2024-02-24.sql" is already used by another PR.

It won't need new human tests after that. But the PR should not be merged as it is.

avatar richard67
richard67 - comment - 24 Feb 2024

P.S.: Or let me know if I shall do that for you, rename the update SQL scripts.

avatar bembelimen bembelimen - change - 24 Feb 2024
Labels Added: RTC Updates Requested
avatar bembelimen
bembelimen - comment - 24 Feb 2024

Thanks for the find @richard67 I have changed it!

avatar richard67 richard67 - change - 24 Feb 2024
Labels Removed: Updates Requested
avatar LadySolveig LadySolveig - change - 25 Feb 2024
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2024-02-25 00:48:43
Closed_By LadySolveig
avatar LadySolveig LadySolveig - close - 25 Feb 2024
avatar LadySolveig LadySolveig - merge - 25 Feb 2024
avatar LadySolveig
LadySolveig - comment - 25 Feb 2024

Thank you @bembelimen ? and for the diligent testers and support @brianteeman @chmst @Quy @crommie @devcodemonkey @richard67

Add a Comment

Login with GitHub to post a comment