User tests: Successful: Unsuccessful:
Pull Request for Issue # .
This PR adds a "Generic" schema.org type which offers a JSON field to add any schema.org JSON-LD.
No Generic type available
Generic type available
Status | New | ⇒ | Pending |
Category | ⇒ | SQL Administration com_admin Postgresql Language & Strings Installation Front End Plugins |
Labels |
Added:
Language Change
PR-5.1-dev
|
I think a better name for this plugin would be Custom and not Generic
Generic means it is something suitable for everything
Custom means it is something unique and specific
But its a close call and probably something lost in translation anyway
I think a better name for this plugin would be Custom and not Generic
Generic means it is something suitable for everything Custom means it is something unique and specific
But its a close call and probably something lost in translation anyway
As I'm not native, I can't judge, so will change it to "custom" in the next days.
Category | SQL Administration com_admin Postgresql Language & Strings Installation Front End Plugins | ⇒ | SQL Administration com_admin Postgresql Language & Strings Installation Libraries Front End Plugins |
Trying to test this but everything /I have tried to paste gives an error
For example I took this json from another page - validated at google and then tried to paste it.
Am I doing something wrong?
{
"@context": "https://schema.org",
"@graph": [
{
"@type": "Organization",
"@id": "https://j5.test/#/schema/Organization/base",
"name": "Joomla CMS Test",
"url": "https://j5.test/"
},
{
"@type": "WebSite",
"@id": "https://j5.test/#/schema/WebSite/base",
"url": "https://j5.test/",
"name": "Joomla CMS Test",
"publisher": {
"@id": "https://j5.test/#/schema/Organization/base"
},
"potentialAction": {
"@type": "SearchAction",
"target": "https://j5.test/search?q={search_term_string}",
"query-input": "required name=search_term_string"
}
},
{
"@type": "WebPage",
"@id": "https://j5.test/#/schema/WebPage/base",
"url": "https://j5.test/typography",
"name": "Typography",
"isPartOf": {
"@id": "https://j5.test/#/schema/WebSite/base"
},
"about": {
"@id": "https://j5.test/#/schema/Organization/base"
},
"inLanguage": "en-GB"
},
{
"@type": "Article",
"@id": "https://j5.test/#/schema/com_content/article/122",
"name": "Typography",
"headline": "Typography",
"inLanguage": "en-GB",
"isPartOf": {
"@id": "https://j5.test/#/schema/WebPage/base"
}
}
]
}
The schema is only for the item, not the full website, so your JSON could look like:
{
"@context": "https://schema.org",
"@type": "Article",
"@id": "https://j5.test/#/schema/com_content/article/122",
"name": "Typography",
"headline": "Typography",
"inLanguage": "en-GB",
"isPartOf": {
"@id": "https://j5.test/#/schema/WebPage/base"
}
}
I have tested this item ✅ successfully on 13737cb
The schema is only for the item, not the full website, so your JSON could look like:
Thanks - all tested and working as far as i can tell
I have tested this item ✅ successfully on 13737cb
Thanks @LadySolveig
I have tested this item ? unsuccessfully on 53793d0
No generic schema type available after applying patch. Maybe I'm just not good at following instructions?
I have tested this item ✅ successfully on 53793d0
Labels |
Added:
Feature
PBF
|
I have tested this item ✅ successfully on 9182a05
After I installed 5.1.0 beta 1 + PR 42699 package, everything works as expected.
I activated the plugin, opened an article, selected Custom (no longer "generic") and pasted the above valid JSON code.
No errors, everything fine.
Status | Pending | ⇒ | Ready to Commit |
RTC
@bembelimen The update SQL scripts need to be renamed from "5.1.0-2024-01-18.sql" to something newer than "5.1.0-2024-02-10.sql", which is the latest update SQL at the moment in the 5.1-dev branch, otherwise they will not run when updating from 5.1.0-alpha4 to beta1. I suggest to use "5.1.0-2024-02-25.sql", as "5.1.0-2024-02-24.sql" is already used by another PR.
It won't need new human tests after that. But the PR should not be merged as it is.
P.S.: Or let me know if I shall do that for you, rename the update SQL scripts.
Labels |
Added:
RTC
Updates Requested
|
Thanks for the find @richard67 I have changed it!
Labels |
Removed:
Updates Requested
|
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-02-25 00:48:43 |
Closed_By | ⇒ | LadySolveig |
Thank you @bembelimen ? and for the diligent testers and support @brianteeman @chmst @Quy @crommie @devcodemonkey @richard67
Please update
libraries\src\Extension\ExtensionHelper