User tests: Successful: Unsuccessful:
Removed hard-coded references to the 'checked_out' database column and replaced them with variables containing the column alias, obtained through a $this->getColumnAlias() call. Now, the 'checked_out' column references mirror the 'published' column references in their respect for column aliasing.
Pull Request for Issue #42688 .
Removed hard-coded references to the 'checked_out' database column and replaced them with variables containing the column alias, obtained through a $this->getColumnAlias() call. Now, the 'checked_out' column references mirror the 'published' column references in their respect for column aliasing. Also made sure the '=' operators lined up nicely in the variable declaration/initialization lines while I was at it.
Change the published state of one or more items whose data are stored in a nested table, i.e. the Tags component to ensure the change did not break existing functionality. To verify new support for aliasing, instantiate the class and call the publish() method from a client that uses an alias for the 'checked_out' column.
Attempting to change the published state of an item in a custom admin list view failed with error message, "Unknown column 'checked_out' in 'where clause'". The database column was properly aliased in the table's __construct() method with the following code:
$this->setColumnAlias('checked_out', 'checked_out_user_id');
Attempting to change the published state of an item in a custom admin list view succeeds.
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
Status | New | ⇒ | Pending |
Category | ⇒ | Libraries |
I have tested this item ✅ successfully on 91c827d
Status | Pending | ⇒ | Ready to Commit |
Labels |
Added:
PR-4.4-dev
|
RTC
Labels |
Added:
RTC
|
Thank you!
Thank you!
You're quite welcome--it's so nice to be able to give back, even if in just this tiny way. :)
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-02-05 20:08:52 |
Closed_By | ⇒ | MacJoom |
I have tested this item ✅ successfully on 91c827d
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42697.