RTC PR-4.4-dev Pending

User tests: Successful: Unsuccessful:

avatar skillet-actual
skillet-actual
22 Jan 2024

Removed hard-coded references to the 'checked_out' database column and replaced them with variables containing the column alias, obtained through a $this->getColumnAlias() call. Now, the 'checked_out' column references mirror the 'published' column references in their respect for column aliasing.

Pull Request for Issue #42688 .

Summary of Changes

Removed hard-coded references to the 'checked_out' database column and replaced them with variables containing the column alias, obtained through a $this->getColumnAlias() call. Now, the 'checked_out' column references mirror the 'published' column references in their respect for column aliasing. Also made sure the '=' operators lined up nicely in the variable declaration/initialization lines while I was at it.

Testing Instructions

Change the published state of one or more items whose data are stored in a nested table, i.e. the Tags component to ensure the change did not break existing functionality. To verify new support for aliasing, instantiate the class and call the publish() method from a client that uses an alias for the 'checked_out' column.

Actual result BEFORE applying this Pull Request

Attempting to change the published state of an item in a custom admin list view failed with error message, "Unknown column 'checked_out' in 'where clause'". The database column was properly aliased in the table's __construct() method with the following code:

$this->setColumnAlias('checked_out', 'checked_out_user_id');

Expected result AFTER applying this Pull Request

Attempting to change the published state of an item in a custom admin list view succeeds.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar skillet-actual skillet-actual - open - 22 Jan 2024
avatar skillet-actual skillet-actual - change - 22 Jan 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 22 Jan 2024
Category Libraries
avatar alikon alikon - test_item - 29 Jan 2024 - Tested successfully
avatar alikon
alikon - comment - 29 Jan 2024

I have tested this item ✅ successfully on 91c827d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42697.

avatar viocassel viocassel - test_item - 30 Jan 2024 - Tested successfully
avatar viocassel
viocassel - comment - 30 Jan 2024

I have tested this item ✅ successfully on 91c827d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42697.

avatar Quy Quy - change - 30 Jan 2024
Status Pending Ready to Commit
Labels Added: PR-4.4-dev
avatar Quy
Quy - comment - 30 Jan 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42697.

avatar Quy Quy - change - 30 Jan 2024
Labels Added: RTC
avatar MacJoom
MacJoom - comment - 5 Feb 2024

Thank you!

avatar skillet-actual
skillet-actual - comment - 5 Feb 2024

Thank you!

You're quite welcome--it's so nice to be able to give back, even if in just this tiny way. :)

avatar MacJoom MacJoom - change - 5 Feb 2024
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2024-02-05 20:08:52
Closed_By MacJoom
avatar MacJoom MacJoom - close - 5 Feb 2024
avatar MacJoom MacJoom - merge - 5 Feb 2024

Add a Comment

Login with GitHub to post a comment