[#42695] - [5.0] Implement Schema.org support for Menu Items
- Closed
- 22 Jan 2024
- Medium
- Build: 5.0-dev
- # 42695
- Diff
- krileon:5.0-dev
User tests: Successful: Unsuccessful:
Summary of Changes
Implements same Article and Contact Schema.org parameters and parsing into JSON-LD for Menu Items. This allows extensions and other custom pages to leverage Schema.org JSON-LD without needing any additional development.
Testing Instructions
- Edit, publish, and save "Content - Joomla" plugin
- Edit, publish, and save "System - Schema.org" plugin
- Create or edit a new menu item
- Configure and save data under the Schema tab as you would with an Article
- Navigate to that menu item on frontend
- Press F12 to open your browsers developer tools
- Review the to make sure your JSON-LD Schema data is present
This is dependent on the menu id being explicitly loaded. So with SEO off that would be Itemid in the URL. Schema data is also cached by default so if you accessed the menu item before saving your schema data be sure to clear your cache or turn off caching of schema data.
Actual result BEFORE applying this Pull Request
No Schema tab in menu edit/create
Expected result AFTER applying this Pull Request
Schema tab in menu edit/create
Link to documentations
Please select:
- Documentation link for docs.joomla.org:
- No documentation changes for docs.joomla.org needed
- Pull Request link for manual.joomla.org:
- No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_menus Language & Strings Front End Plugins |
The only thing I was able to confirm was that the schema tab appeared in the menu edit.
Nothing was created
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42695.
The only thing I was able to confirm was that the schema tab appeared in the menu edit.
Nothing was created
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42695.
It's entirely menu item based. You need to be sure you're on the correct menu item. So Itemid will matter. You need to of course ensure the Schema plugins are all enabled and working as it's using the same behavior and implementation that articles and contacts use.
The Schema data should also exist in _schemaorg table for that menu item attached to its menu id with a com_menus.item context.
It's entirely menu item based. You need to be sure you're on the correct menu item. So Itemid will matter.
Confirmed
The Schema data should also exist in _schemaorg table for that menu item attached to its menu id with a com_menus.item context.
Confirmed
Nothing in the front end
It's entirely menu item based. You need to be sure you're on the correct menu item. So Itemid will matter.
Confirmed
The Schema data should also exist in _schemaorg table for that menu item attached to its menu id with a com_menus.item context.
Confirmed
Nothing in the front end
Edit and save "Content - Joomla" and "System - Schema.org" plugins. Then clear Joomla cache. Had this same issue with Articles.
It's working for me in my tests. So beyond that I don't know what to suggest.
Menu:
JSON-LD:
Edit and save "Content - Joomla" and "System - Schema.org" plugins. Then clear Joomla cache. Had this same issue with Articles.
Already done
This allows extensions and other custom pages to leverage Schema.org JSON-LD without needing any additional development.
Are you sure that you tested this with a menu item that was NOT for com_content - your screenshot implies that you were testing com_content
Edit and save "Content - Joomla" and "System - Schema.org" plugins. Then clear Joomla cache. Had this same issue with Articles.
Already done
This allows extensions and other custom pages to leverage Schema.org JSON-LD without needing any additional development.
Are you sure that you tested this with a menu item that was NOT for com_content - your screenshot implies that you were testing com_content
That's a good point. Yeah I only tested com_content menu items. So there's probably a check somewhere checking the component. Probably isSupported in the Schemaorg plugin.
it does work for com_content but thats all.
I suggest you close this for now (saves other people from wasting their time) and then re-open it when you have tested this
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-01-22 18:33:28 |
| Closed_By | ⇒ | krileon | |
| Labels |
Added:
Language Change
PR-5.0-dev
|
||
Thank you for your work on this @krileon. A nice idea to have this also in menu items. I would appreciate it if you could reopen this PR in the 5.1-dev branch, as it is a new feature. Please mark it as draft while you are still working on it until the other components are also supported. It is not necessary to close it.
| Status | Closed | ⇒ | New |
| Closed_Date | 2024-01-22 18:33:28 | ⇒ | |
| Closed_By | krileon | ⇒ |
| Status | New | ⇒ | Pending |
| Title |
|
||||||
| Category | Administration com_menus Language & Strings Front End Plugins | ⇒ | Unit Tests Repository Administration com_menus Language & Strings NPM Change Installation |
Thank you for your work on this @krileon. A nice idea to have this also in menu items. I would appreciate it if you could reopen this PR in the 5.1-dev branch, as it is a new feature. Please mark it as draft while you are still working on it until the other components are also supported. It is not necessary to close it.
I'm going to have to completely rebase this to 5.1 then. I didn't know 5.0 was feature locked.
Will implement for 5.1. Test multiple core components and create a separate new PR for the new 5.1 based branch.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-01-22 19:22:04 |
| Closed_By | ⇒ | krileon | |
| Labels |
Added:
Unit/System Tests
NPM Resource Changed
PR-5.1-dev
|
||
| Category | Administration com_menus Language & Strings Unit Tests Repository NPM Change Installation | ⇒ | Administration com_menus Language & Strings Front End Plugins |
| Title |
|
||||||
I have tested this item ? unsuccessfully on 6a897e8
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42695.