bug PR-4.4-dev Pending

User tests: Successful: Unsuccessful:

avatar Hackwar
Hackwar
22 Jan 2024

Summary of Changes

While debugging another issue, I stumbled upon a problem where the language handed over for a token while indexing is being set to NULL. For this to happen, Finder needs to be set to search for phrases. In that case, the changed line applies the stemming code to each token, but since $lang is only a single entry array, that variable is only applied once for the array of tokens. The token array can have between 1 and 3 entries and thus the stemmer for $lang is only applied for the first token and not the rest of the array.

Testing Instructions

Codereview.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar Hackwar Hackwar - open - 22 Jan 2024
avatar Hackwar Hackwar - change - 22 Jan 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 22 Jan 2024
Category Administration com_finder
avatar Hackwar Hackwar - change - 23 Jan 2024
Labels Added: PR-4.4-dev
avatar MacJoom MacJoom - change - 22 Feb 2024
Labels Added: bug
avatar MacJoom MacJoom - change - 22 Feb 2024
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2024-02-22 09:55:02
Closed_By MacJoom
avatar MacJoom MacJoom - close - 22 Feb 2024
avatar MacJoom MacJoom - merge - 22 Feb 2024

Add a Comment

Login with GitHub to post a comment