RTC NPM Resource Changed PR-4.4-dev Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
22 Jan 2024

Pull Request for Issue #41839 .

Summary of Changes

  • Truncate filename in media actions menu
  • set max width on media-browser-item-info

Testing Instructions

Using the image select in the images and links tab of a new article

  • rename an image to something crazy long
  • close the image select
  • re-open the image select

as this an scss change you will need to test with either one of the prebuilt packages or npm run ci after applying the pr

Actual result BEFORE applying this Pull Request

image

image

Expected result AFTER applying this Pull Request

image

image

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@crystalenka This touches some css you wrote so it would be good to have a check if you have time please.

@hans2103 CSS is not really my thing so a check would be appreciated

avatar brianteeman brianteeman - open - 22 Jan 2024
avatar brianteeman brianteeman - change - 22 Jan 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 22 Jan 2024
Category Repository NPM Change
avatar brianteeman brianteeman - change - 22 Jan 2024
The description was changed
avatar brianteeman brianteeman - edited - 22 Jan 2024
avatar laoneo laoneo - test_item - 22 Jan 2024 - Tested successfully
avatar laoneo
laoneo - comment - 22 Jan 2024

I have tested this item ✅ successfully on 1a477c5


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42691.

avatar laoneo
laoneo - comment - 22 Jan 2024

Having a file with a long name wrapps the media manager like:
image

With the patch, everything looks normal:
image

avatar viocassel viocassel - test_item - 22 Jan 2024 - Tested successfully
avatar viocassel
viocassel - comment - 22 Jan 2024

I have tested this item ✅ successfully on 1a477c5


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42691.

avatar Quy Quy - change - 22 Jan 2024
Status Pending Ready to Commit
Labels Added: NPM Resource Changed PR-4.4-dev
avatar Quy
Quy - comment - 22 Jan 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42691.

avatar Quy Quy - change - 22 Jan 2024
Labels Added: RTC
avatar MacJoom
MacJoom - comment - 22 Jan 2024

Thanks!

avatar MacJoom MacJoom - change - 22 Jan 2024
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2024-01-22 15:49:47
Closed_By MacJoom
avatar MacJoom MacJoom - close - 22 Jan 2024
avatar MacJoom MacJoom - merge - 22 Jan 2024
avatar brianteeman
brianteeman - comment - 22 Jan 2024

Thanks - please close the issue this was created for

avatar Mich-es
Mich-es - comment - 22 Jan 2024

Thanks!

Add a Comment

Login with GitHub to post a comment