RTC PHP 8.x bug PR-4.4-dev Pending

User tests: Successful: Unsuccessful:

avatar Hackwar
Hackwar
17 Jan 2024

Pull Request for Issue #41824.

Summary of Changes

In PHP 8.2, the changed line creates a notice when calling a category blog view with ?format=feed&type=atom attached to the URL. This fixes that.

Testing Instructions

  1. Open a category blog page on a site on PHP 8.2 and attach ?format=feed&type=atom to the URL.
  2. Look at the output.

Actual result BEFORE applying this Pull Request

A notice is shown:
Deprecated: htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated in /home/www/libraries/src/Document/Renderer/Feed/AtomRenderer.php on line 89

Expected result AFTER applying this Pull Request

The notice is not there.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar Hackwar Hackwar - open - 17 Jan 2024
avatar Hackwar Hackwar - change - 17 Jan 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 17 Jan 2024
Category Libraries
avatar MacJoom MacJoom - test_item - 18 Jan 2024 - Tested successfully
avatar MacJoom
MacJoom - comment - 18 Jan 2024

I have tested this item ✅ successfully on 5c66558

On Jooma 4.4-dev PHP 8.2


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42670.

avatar viocassel viocassel - test_item - 18 Jan 2024 - Tested successfully
avatar viocassel
viocassel - comment - 18 Jan 2024

I have tested this item ✅ successfully on 5c66558


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42670.

avatar richard67 richard67 - change - 18 Jan 2024
Status Pending Ready to Commit
Labels Added: PBF PHP 8.x PR-4.4-dev
avatar richard67
richard67 - comment - 18 Jan 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42670.

avatar Quy Quy - change - 19 Jan 2024
Labels Added: RTC bug
Removed: PBF
avatar laoneo laoneo - close - 19 Jan 2024
avatar laoneo laoneo - merge - 19 Jan 2024
avatar laoneo laoneo - change - 19 Jan 2024
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2024-01-19 14:42:17
Closed_By laoneo
avatar laoneo
laoneo - comment - 19 Jan 2024

Thanks!

Add a Comment

Login with GitHub to post a comment