Language Change PR-5.1-dev Pending

User tests: Successful: Unsuccessful:

avatar tecpromotion
tecpromotion
17 Jan 2024

Summary of Changes

This small patch standardises the spelling for occurrences of "_MANAGE_LANGUAGES_CONTENT"

See

MOD_MENU_MANAGE_LANGUAGES_CONTENT="Content Languages"

and
COM_INSTALLER_TOOLBAR_MANAGE_CONTENT_LANGUAGES="Content Languages"

Testing Instructions

code review

Actual result BEFORE applying this Pull Request

Two notations for two equivalent constants.

Expected result AFTER applying this Pull Request

Standardised spelling

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar tecpromotion tecpromotion - open - 17 Jan 2024
avatar tecpromotion tecpromotion - change - 17 Jan 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 17 Jan 2024
Category Administration com_installer Language & Strings
avatar heelc29 heelc29 - test_item - 17 Jan 2024 - Tested successfully
avatar heelc29
heelc29 - comment - 17 Jan 2024

I have tested this item ✅ successfully on 75eb4ee


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42663.

avatar brianteeman
brianteeman - comment - 17 Jan 2024

Unfortunately you can nont do this https://developer.joomla.org/development-strategy.html

Changing or deleting a language key is considered a backwards compatibility break. Adding new ones is not. Substantially changing the meaning associated with a language key is a compatibility break. Rephrasing something for a more accurate description or proper en-GB grammar is not.

avatar heelc29
heelc29 - comment - 17 Jan 2024

@brianteeman The language string (COM_INSTALLER_TOOLBAR_MANAGE_CONTENT_LANGUAGES) you mean was added yesterday with #42610 and is not yet included in any public release -> so it should be ok.

avatar brianteeman
brianteeman - comment - 17 Jan 2024

ok then

avatar LadySolveig LadySolveig - change - 17 Jan 2024
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2024-01-17 15:30:27
Closed_By LadySolveig
Labels Added: Language Change PR-5.1-dev
avatar LadySolveig LadySolveig - close - 17 Jan 2024
avatar LadySolveig LadySolveig - merge - 17 Jan 2024
avatar LadySolveig
LadySolveig - comment - 17 Jan 2024

Thank you @tecpromotion

Add a Comment

Login with GitHub to post a comment