[#42662] - [5.2] Schema.org: Fix error when menu item doesn't exist
- Pending
- Medium
- Build: 5.0-dev
- # 42662
- Diff
- Hackwar:5.0-schema-menu
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Summary of Changes
When having the schema.org plugin enabled and opening a URL with a non-existing Itemid, the plugin throws a fatal error.
Testing Instructions
- Open a URL like
index.php?Itemid=666&option=com_content&view=category&id=2 - See the fatal error
- Apply patch
- See error go away.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
You have to open the URL in the frontend.
I have tested this item ✅ successfully on 0c0938c
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42662.
I have tested this item ✅ successfully on 0c0938c
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42662.
rdeutz
- | Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
RTC
PR-5.0-dev
|
||
I think tis is the wrong approach, just because there is no menu (not sure if this ever should happen...but that's another topic) you should not skip all the output.
It just needs a headline and a clean check for meta data. The headline should be available somewhere (I mean, it's there in the normal output) and the if for the meta can add the $menu && ....
But again, don't disable the whole schema output just because there is no menu.
| Status | Ready to Commit | ⇒ | Pending |
This issue only shows up when the Itemid is invalid, so when the Itemid points to a non-existing menu item. In that case we are missing large parts of our configuration and should thus disable the schema output. This is NEVER a site which you want to have indexed. Remember, when we have a /component/content/category page, we still fall back to the default menu item. This only happens when the page really is broken. I also don't see how we could do this more gracefully, since we are missing a name for the blog and the description. I would still ask to merge this as is.
If it's a broken page, then throw an error? Make a redirect? Make it no-index?
If it's a broken page, then throw an error? Make a redirect? Make it no-index?
The page does not exist. It's an empty category with no articles in it as I described in https://forum.joomla.org/viewtopic.php?f=834&t=1006471
I have disabled the Schema org plugin which fixes the issue for now (to avoid getting 500 errors in Google Search Console).
| Title |
|
||||||
I have tested this item ✅ successfully on 949a0da
Works fine!
After applying patch i got this message instead of an error: There are no articles in this category. If subcategories display on this page, they may have articles.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42662.
I have tested this item ✅ successfully on 949a0da
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42662.
I have tested this item ✅ successfully on 949a0da
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42662.
| Labels |
Added:
PBF
bug
RMDQ
PR-5.1-dev
Removed: RTC PR-5.0-dev |
||
I have tested this item ✅ successfully on 0c0938c
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42662.
Removed RTC, see: #42662 (comment)
Just fix line 319 + 323 instead of throwing everything away
This pull request has been automatically rebased to 5.2-dev.
| Title |
|
||||||
Error
View not found [name, type, prefix]: category, html, Administratorstay with applied patch.