[#42638] - [4.4] Fix parameter type for whereIn query in ExtensionsHelper - issue 42637
- Fixed in Code Base
- 10 Jan 2024
- Medium
- Build: 4.4-dev
- # 42638
- Diff
- richard67:4.4-dev-fix-extensions-helper-where-in-data-type
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #42637 .
Summary of Changes
This pull request (PR) adds the missing $dataType parameter to the call of $query->whereIn for the query which has been modified with PR #42576 , which caused a regression in Joomla 4.4.2 and 5.0.2 regarding filtering for core or non-core extensions in the Extensions Manager.
The default value of that parameter is ParameterType::INTEGER, so the missing parameter in the call caused the strings to be bound as integers. Depending on the database type and version, this may cause the regression or it may not cause it when the database does an implicit cast to string. This might be the reason why I haven't noticed my mistake when testing my PR #42576 .
Testing Instructions
Pre-conditions
This PR should be tested on a current 4.4-dev branch or on a 4.4.2. Do not use 4.4.1 or older because with that you will not be able to reproduce the issue.
If you can test only with Joomla 5, use a current 5.0-dev branch or a 5.0.2. You can apply the same change from this PR here also on a 5.0-dev branch or a 5.0.2 by manual edit of the modified file. Do not use 5.0.1 or 5.0.0 because with that you will not be able to reproduce the issue.
It might also depend on the database type (MySQL or MariaDB) and the database version if you can reproduce the issue or not.
Procedure
Go to extensions manage and filter by core/non-core extensions.
Actual result BEFORE applying this Pull Request
Non-core filter produces zero results.
Core filter produces results for the non-core extensions only.
Expected result AFTER applying this Pull Request
Filtering works as expected.
Link to documentations
Please select:
-
No documentation changes for docs.joomla.org needed
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
bug
PR-4.4-dev
|
||
I have tested this item ✅ successfully on 6897cc0
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42638.
I have tested this item ✅ successfully on 6897cc0
Tested on J4.4.2
Works after applying patch manually.
PS: Zero results before for non-core and all results in core (non+core). After it shows non-core at non-core and core at core filter.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42638.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42638.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-01-10 18:22:35 |
| Closed_By | ⇒ | MacJoom | |
| Labels |
Added:
RTC
|
||
Thank you!
Thanks all testers and for merging.
After manual installation on 4.4.2 says still no ext installed and all checkmarks green although several third developer ext. exist.
After manual installation on 4.4.2 says still no ext installed and all checkmarks green although several third developer ext. exist.
@some1new You might have to trigger the pre-update check again by using the button to search for updates, and make sure that you really have applied the change. You can e.g. download the changed file from here https://raw.githubusercontent.com/joomla/joomla-cms/4.4-dev/libraries/src/Extension/ExtensionHelper.php and then upload it to your site into the "libraries/src/Extension" folder.
After manual installation on 4.4.2 says still no ext installed and all checkmarks green although several third developer ext. exist.
@some1new You might have to trigger the pre-update check again by using the button to search for updates, and make sure that you really have applied the change. You can e.g. download the changed file from here https://raw.githubusercontent.com/joomla/joomla-cms/4.4-dev/libraries/src/Extension/ExtensionHelper.php and then upload it to your site into the "libraries/src/Extension" folder.
My fault, updated a different website to check.
All fine.
This pr will be published with 4.4.3 as you can see in the target milestone.
As intermediate solution you can apply the changes from this pull request manually.
tested with 4.4.2
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42638.