Feeling Lucky
RTC
PR-4.4-dev
[#42635] - Define correct type for field helper doc
- Fixed in Code Base
- 10 Jan 2024
- Medium
- Build: 4.4-dev
- # 42635
- Diff
- Digital-Peak:fields/comment
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
The $item parameter FieldsHelper::getFields has to be an object or array and not null.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_fields |
laoneo
- comment
- 10 Jan 2024
Use a debugger and check the types of $item while working with custom fields. But as you can see in the code, it can be an object, array or null. The doc comment is wrong as it can, but not must, be null.
If you want to test something as this one here is just cosmetic, better to look at #42473.
sandewt
- comment
- 10 Jan 2024
I have tested this item ✅ successfully on 37df313
cosmetically tested by just looking at the code
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42635.
chmst
- comment
- 10 Jan 2024
I have tested this item ✅ successfully on 37df313
Working on differnt applications with custom fields. No problem with this PR.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42635.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
PR-4.4-dev
|
||
Quy
- comment
- 10 Jan 2024
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42635.
| Labels |
Added:
RTC
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-01-10 19:22:33 |
| Closed_By | ⇒ | MacJoom |
I don't understand this, because in line 108 $item gets the value null? You probably mean something else.
joomla-cms/administrator/components/com_fields/src/Helper/FieldsHelper.php
Line 108 in 37df313
In line 128 I can see that the variable $item can be an array.
joomla-cms/administrator/components/com_fields/src/Helper/FieldsHelper.php
Line 128 in 37df313
How can I best test this PR?