[#42608] - [4.4] Improve Totp code input
- Fixed in Code Base
- 19 Jan 2024
- Medium
- Build: 4.4-dev
- # 42608
- Diff
- sitecode:4.4-dev
User tests: Successful: Unsuccessful:
-
Fix code input pattern attribute
-
Specify autocomplete on code input
Pull Request for Issue # .
Summary of Changes
Fix JS pattern attribute error for code input element: Pattern attribute value {0,9} is not a valid regular expression: Uncaught SyntaxError: Invalid regular expression: /{0,9}/v: Nothing to repeat
Prevent auto completion of code input element. Can cause trouble for certain users, when the browser tries to autofill past values as they enter in the current code.
I intend this fix to also apply to Joomla 5. I assume that this pull request will magically apply there as well. Otherwise please instruct me how to pull that off assuming this moves forward.
Testing Instructions
In Chrome go to setup MFA, start typing code in code input element and JS pattern error appears in console.
Actual result BEFORE applying this Pull Request
- JS error.
- Autocomplete entries show from past codes entered.
Expected result AFTER applying this Pull Request
- JS error resolved, doesn't show. And form submission not allowed until 6 numbers entered.
- Code input element doesn't remember past entries.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
| Labels |
Added:
PR-4.4-dev
|
||
I have tested this item ✅ successfully on e0bdbfb
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42608.
| Labels |
Added:
bug
Maintainers Checked
|
||
I have tested this item ✅ successfully on 2d7346b
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42608.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42608.
| Labels |
Added:
RTC
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-01-19 14:44:09 |
| Closed_By | ⇒ | laoneo |
Thanks!
Is this correct. Seems to me that there are two conflicting settings
autocomplete = one-time-code
aria-autocomplete = none
The first defines the type of data a browser can use to autocomplete the field but the second one turns off the ability to autocomplete the input
I'm not quite happy with this PR for the following reasons:
But as the description only deals with Chrome, the PR does what it is supposed to do. Therefore, I will post a positive test result.