[#42606] - Change type of field "value" in table #_fields_values from text to mediumtext
- Fixed in Code Base
- 26 Jan 2024
- Medium
- Build: 5.1-dev
- # 42606
- Diff
- sergeytolkachyov:5.1-dev
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Change type of field "value" in table #_fields_values from text to mediumtext for MySQL ONLY. PostgreSQL have only text field type with unlimited length. Pull Request for Issue #36065 and remake a PR #42605 for Joomla 5.1.0
Testing instructions
- Go to bottom of this PR and click Show all checks in All checks have passed section
- Click on Details in download line
- You will go to https://artifacts.joomla.org/drone/joomla/joomla-cms/5.1-dev/42606/downloads/72696/
- Download Full installation package and update package of Joomla 5.1 + this PR
- Make a clean install from
Joomla_5.1.0-alpha3-dev+pr.42606-Development-Full_Package.zip - Go to PhpMyAdmin, select database you used for clean install and go to the
#__field_valuestable. Then go to structure section and check that type ofvaluefield ismediumtext.
- Clean your database and test domain folder and install a Joomla 5.0.1
- Check
valuefield type in PHP My Admin in#__field_valuestable. It is atexttype now.
- Then go to admin panel / System / Update / Joomla . Press the Upload and Update button
- Upload the
Joomla_5.1.0-alpha3-dev+pr.42606-Development-Update_Packageand update
- Then go to PhpMyAdmin again and check the
#__field_valuestable - type of fieldvalue. It could be amediumtext
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | SQL Administration com_admin Installation |
@sergeytolkachyov You reacted with a thumbs up to my previous comment, but you haven't added any testing instructions to the description of this PR yet. Could you do that? Thanks in advance.
@sergeytolkachyov You reacted with a thumbs up to my previous comment, but you haven't added any testing instructions to the description of this PR yet. Could you do that? Thanks in advance.
Yes, I'll do that
Just an off topic comment, if you working heavily with custom fields: you can improve the performance enormous when you change the item_id column to integer instead of varchar.
But for this change we need a small kind of migration, but I think worth to investigate (if you're up for another PR)
@sergeytolkachyov You reacted with a thumbs up to my previous comment, but you haven't added any testing instructions to the description of this PR yet. Could you do that? Thanks in advance.
Done
Done
Thanks.
Just an off topic comment, if you working heavily with custom fields: you can improve the performance enormous when you change the
item_idcolumn to integer instead of varchar.But for this change we need a small kind of migration, but I think worth to investigate (if you're up for another PR)
@bembelimen It did that in my application with about 40k fields_values and it makes such an incredible huge difference. I would really appreciate and support a PR for that.
@richard67 @bembelimen not merged?
@sergeytolkachyov You should know that
- Every non trivial pull request needs 2 successful tests by human testers before it can be merged, and
- I am not a release manager so I won’t decide anything.
quite every pr needs 2 human test
I have tested this item ✅ successfully on a7badaa
code review
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42606.
quite every pr needs 2 human test
Yes, if it’s not just a typo in a comment, that’s what I mean with „non trivial“.
Strangely, for some reason I remembered that 2 necessary tests had already been done.
Strangely, for some reason I remembered that 2 necessary tests had already been done.
@sergeytolkachyov Where? Here in the PR I can not see any human test results except of the one from a few minutes ago.
Strangely, for some reason I remembered that 2 necessary tests had already been done.
@sergeytolkachyov Where? Here in the PR I can not see any human test results except of the one from a few minutes ago.
I wrote to 3 humans for testing now. Thank you
I have tested this item ✅ successfully on a7badaa
Successfully tested
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42606.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
Feature
PR-5.1-dev
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42606.
| Labels |
Added:
RTC
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-01-26 12:00:43 |
| Closed_By | ⇒ | Razzo1987 |
Thanks!
@sergeytolkachyov By review your PR looks good to me. But it would be good if you could provide some testing instructions. When you create a pull request, there are already headings for testing instructions and so on in the description. This is intended to be completed by the author, not to be removed completely. Possible testing instructions could be to make a new installation and check the type of the column after that, and to make an update with the package ur custom URL created by drone and check the type of the column after that. Or in this simple case maybe only "Code review". But there should be some testing instructions.