Feature RTC PR-5.1-dev Pending

User tests: Successful: Unsuccessful:

avatar Hackwar
Hackwar
3 Jan 2024

Summary of Changes

The output of the CLI command to update the Joomla core currently is producing very bad output. The way the progressbar is used, all output is more or less deleted right away again and the progressbar is also not really very progressy...

This PR changes the output to keep all messages which were previously written on the screen and to actually display a progressbar.

Testing Instructions

  1. See how the core update on the CLI looks right now.
  2. Apply the changes from this PR.
  3. Change the version in `/libraries/src/Version.php to a lower version like 5.0.0.
  4. Since your DB structure will be a mismatch to our perceived version and the update, we have to comment out the schema check on line 195 of libraries/src/Console/UpdateCoreCommand.php and add $error = 0; in the line below.
  5. Run php cli/joomla.php core:update

Actual result BEFORE applying this Pull Request

Output is really not helpfull.

Expected result AFTER applying this Pull Request

Output is a lot more verbose.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar Hackwar Hackwar - open - 3 Jan 2024
avatar Hackwar Hackwar - change - 3 Jan 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 3 Jan 2024
Category Libraries
avatar alikon alikon - test_item - 4 Jan 2024 - Tested successfully
avatar alikon
alikon - comment - 4 Jan 2024

I have tested this item ✅ successfully on a3c7358


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42601.

avatar dautrich dautrich - test_item - 9 Jan 2024 - Tested successfully
avatar dautrich
dautrich - comment - 9 Jan 2024

I have tested this item ✅ successfully on a3c7358


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42601.

avatar dautrich
dautrich - comment - 9 Jan 2024

Before application of the patch:
grafik

Change to UpdateCoreCommand.php:
grafik
Remark: I suppose item 4 in your Testing Instructions should read $errors = 0

After application of the patch:
grafik

avatar alikon alikon - change - 9 Jan 2024
Status Pending Ready to Commit
avatar alikon
alikon - comment - 9 Jan 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42601.

avatar Razzo1987 Razzo1987 - change - 13 Jan 2024
Labels Added: Feature RTC PR-5.1-dev
avatar Razzo1987 Razzo1987 - change - 13 Jan 2024
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2024-01-13 17:06:30
Closed_By Razzo1987
avatar Razzo1987 Razzo1987 - close - 13 Jan 2024
avatar Razzo1987 Razzo1987 - merge - 13 Jan 2024
avatar Razzo1987
Razzo1987 - comment - 13 Jan 2024

Thanks!

Add a Comment

Login with GitHub to post a comment