Feeling Lucky
RTC
RMDQ
PR-5.1-dev
[#42581] - com_contact. Rm unused order_up, order_dn
- Fixed in Code Base
- 24 Jan 2024
- Medium
- Build: 5.0-dev
- # 42581
- Diff
- ReLater:patch-1
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
order_up and order_dn are not used in Joomla core. Garbage from Joomla 1.6 or so.
Summary of Changes
Removed lines from com_contact list view.
// Preprocess the list of items to find ordering divisions.
// @todo: Complete the ordering stuff with nested sets
foreach ($this->items as &$item) {
$item->order_up = true;
$item->order_dn = true;
}
Testing Instructions
- Check the Joomla core if you find somewhere a code place where properties
order_upororder_dnare used. You won't find one. - Check that
com_contactlist view in Joomla backend works like before when these lines are removed. - @Kubik-Rubik confirmed in german Joomla forum that these lines are garbage from Joomla 1.6 or so.
Actual result BEFORE applying this Pull Request
- Unused garbage in file.
Expected result AFTER applying this Pull Request
- No functional changes. Garbage removed.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_contact |
ChristineWk
- comment
- 1 Jan 2024
I have tested this item ✅ successfully on f1ac63e
Joomla 5.1.0-alpha2
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42581.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
PR-5.0-dev
|
||
richard67
- comment
- 1 Jan 2024
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42581.
richard67
- comment
- 1 Jan 2024
RTC as it has 2 successful tests ... but it needs to be clarified with maintainers or release managers if this should be rebased to 5.1-dev.
bembelimen
- comment
- 2 Jan 2024
Yes, 5.1 please
| Labels |
Added:
RTC
RMDQ
|
||
| Category | Administration com_contact | ⇒ | Administration com_contact com_joomlaupdate Language & Strings Repository NPM Change Libraries JavaScript Unit Tests |
| Labels |
Added:
Unit/System Tests
Language Change
NPM Resource Changed
PR-5.1-dev
Removed: PR-5.0-dev |
||
| Category | Administration com_contact com_joomlaupdate Language & Strings Repository NPM Change Libraries JavaScript Unit Tests | ⇒ | Administration com_contact |
| Labels |
Removed:
Unit/System Tests
Language Change
NPM Resource Changed
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-01-24 17:41:53 |
| Closed_By | ⇒ | LadySolveig |
LadySolveig
- comment
- 24 Jan 2024
Thank you @ReLater and also for testing @ChristineWk and @Quy !
I have tested this item ✅ successfully on f1ac63e
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42581.