User tests: Successful: Unsuccessful:
Pull Request for Issue #42537 .
Provide a better warning message on package uninstallation when an extension from that package is missing by mentioning the name of that extension in the message.
A new language string is added for this purpose, which is more or less the same as the first part of the existing JLIB_INSTALLER_ERROR_PACK_UNINSTALL_NOT_PROPER
string and uses the same parameter.
The package adapter uses the new string in the same way as the JLIB_INSTALLER_ERROR_PACK_UNINSTALL_NOT_PROPER
string, i.e. the extensions name is obtained with basename($extension->filename))
.
The old language string JLIB_INSTALLER_ERROR_PACK_UNINSTALL_UNKNOWN_EXTENSION
is obsolete and therefore deprecated.
Packages for new installation and updates and a custom update URL created by Drone for this PR can be found here: https://artifacts.joomla.org/drone/joomla/joomla-cms/4.4-dev/42570/downloads/72522 .
There is a warning message "Trying to uninstall unknown extension from package. This extension may have already been removed earlier.".
There is a warning message which contains the name of the extensions, e.g. "Package Uninstall: This extension is missing or has already been uninstalled: mod_helloworld".
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
Status | New | ⇒ | Pending |
Category | ⇒ | Administration Language & Strings Libraries |
Added a link to the Drone packages and custom update URL to the testing instructions.
In my opinion it is a bug fix. I remember this message in the past. And it could be interesting for users who update from older versions.
I have tested this item ✅ successfully on cbd9ac1
Labels |
Added:
Language Change
PR-4.4-dev
|
Will merge it anyway after drone build succeeds
Ah, ok. Thanks.
Status | Pending | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-12-27 11:26:32 |
Closed_By | ⇒ | MacJoom |
Thanks for the PR!
@chmst Would you say it's a bug fix? Or is it a new feature so it should go into 5.1-dev? I'd like to know your opinion. More opinions are of course welcome.