Language Change PR-4.4-dev Pending

User tests: Successful: Unsuccessful:

avatar richard67
richard67
26 Dec 2023

Pull Request for Issue #42537 .

Summary of Changes

Provide a better warning message on package uninstallation when an extension from that package is missing by mentioning the name of that extension in the message.

A new language string is added for this purpose, which is more or less the same as the first part of the existing JLIB_INSTALLER_ERROR_PACK_UNINSTALL_NOT_PROPER string and uses the same parameter.

The package adapter uses the new string in the same way as the JLIB_INSTALLER_ERROR_PACK_UNINSTALL_NOT_PROPER string, i.e. the extensions name is obtained with basename($extension->filename)).

The old language string JLIB_INSTALLER_ERROR_PACK_UNINSTALL_UNKNOWN_EXTENSION is obsolete and therefore deprecated.

Testing Instructions

Packages for new installation and updates and a custom update URL created by Drone for this PR can be found here: https://artifacts.joomla.org/drone/joomla/joomla-cms/4.4-dev/42570/downloads/72522 .

  1. Install some 3rd party package extension which contains a few extensions of different type, e.g. a component and some modules or plugins.
  2. Uninstall one of these extensions (modules or plugins) from that package.
  3. Uninstall the package and check the warning messages.

Actual result BEFORE applying this Pull Request

There is a warning message "Trying to uninstall unknown extension from package. This extension may have already been removed earlier.".

Expected result AFTER applying this Pull Request

There is a warning message which contains the name of the extensions, e.g. "Package Uninstall: This extension is missing or has already been uninstalled: mod_helloworld".

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar richard67 richard67 - open - 26 Dec 2023
avatar richard67 richard67 - change - 26 Dec 2023
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 26 Dec 2023
Category Administration Language & Strings Libraries
avatar richard67
richard67 - comment - 26 Dec 2023

Looks good for me.

@chmst Would you say it's a bug fix? Or is it a new feature so it should go into 5.1-dev? I'd like to know your opinion. More opinions are of course welcome.

avatar richard67 richard67 - change - 26 Dec 2023
The description was changed
avatar richard67 richard67 - edited - 26 Dec 2023
avatar richard67
richard67 - comment - 26 Dec 2023

Added a link to the Drone packages and custom update URL to the testing instructions.

avatar chmst
chmst - comment - 26 Dec 2023

In my opinion it is a bug fix. I remember this message in the past. And it could be interesting for users who update from older versions.

avatar dautrich dautrich - test_item - 26 Dec 2023 - Tested successfully
avatar dautrich
dautrich - comment - 26 Dec 2023

I have tested this item ✅ successfully on cbd9ac1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42570.

Result after applying the patch:
Bildschirminhalt erfassen-2

Bildschirminhalt erfassen-3

Bildschirminhalt erfassen-4

Result without the patch:
Bildschirminhalt erfassen-1

avatar MacJoom MacJoom - change - 27 Dec 2023
Labels Added: Language Change PR-4.4-dev
avatar richard67
richard67 - comment - 27 Dec 2023

@MacJoom When updating someone’s branch and there is a human test, then please restore the test result in the issue tracker.

avatar MacJoom
MacJoom - comment - 27 Dec 2023

@MacJoom When updating someone’s branch and there is a human test, then please restore the test result in the issue tracker.

Will merge it anyway after drone build succeeds

avatar richard67
richard67 - comment - 27 Dec 2023

Will merge it anyway after drone build succeeds

Ah, ok. Thanks.

avatar MacJoom MacJoom - change - 27 Dec 2023
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-12-27 11:26:32
Closed_By MacJoom
avatar MacJoom MacJoom - close - 27 Dec 2023
avatar MacJoom MacJoom - merge - 27 Dec 2023
avatar MacJoom
MacJoom - comment - 27 Dec 2023

Thanks for the PR!

Add a Comment

Login with GitHub to post a comment