[#4257] - Create postinstall table only if it doesn't exist
- Closed
- 9 Sep 2014
- Medium
- Build: staging
- # 4257
- Diff
- nicksavov:post-install-sql-fix-for-install
- Failure The Travis CI build failed Details
User tests: Successful: Unsuccessful:
jissues-bot
- | Labels |
Added:
?
|
||
Good catch!
My only suggestion is to break that up into different PRs. If code styling is separated from something that could affect functionality, that would make PRs easier to test and code review. Bugs often get introduced when too much is done in one PR.
Not really and that's just making extra work for the sake of it
On 9 Sep 2014 20:54, "Nick Savov" notifications@github.com wrote:
Good catch!
My only suggestion is to break that up into different PRs. If code styling
is separated from something that could affect functionality, that would
make PRs easier to test and code review.—
Reply to this email directly or view it on GitHub
#4257 (comment).
That's your opinion :)
It's not that hard to read through an SQL file and see if there's functionality being changed or if it's all code prettifying (hint, aside from your change here, everything is code beautification 
)
And ENGINE=InnoDB :P
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-09-09 20:28:51 |
@nicksavov this is also in https://github.com/joomla/joomla-cms/pull/4229/files#diff-135c6f58583408312a709459b19594c7R1501