[#42560] - [4.4] Fixes to form validation process
- Fixed in Code Base
- 23 Dec 2023
- Medium
- Build: 4.4-dev
- # 42560
- Diff
- wilsonge:form-bug-fix
User tests: Successful: Unsuccessful:
Fixes hardening measure introduced in #23716
Summary of Changes
In the linked PR I forbid submitting by adding an exception into the validation process. Unfortunately I didn't make the method return false in order to make sure that message was used. This fixes that.
Alongside it improves the documentation around the getError's method. It hasn't returned any strings since 3.0 (and even maybe further - I wasn't sure about how the JException objects were exactly being passed around).
Testing Instructions
Code review
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
I have tested this item ✅ successfully on c246730
Code review.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42560.
Looks good from my side!
@SniperSister Does this count as successful test? If so, could you mark the test result in the issue tracker, or shall I do that for you, so I can set RTC?
I have tested this item ✅ successfully on c246730
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42560.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
PR-4.4-dev
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42560.
MacJoom
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-12-23 16:52:02 |
| Closed_By | ⇒ | MacJoom | |
| Labels |
Added:
RTC
|
||
Looks good from my side!