RTC Language Change PR-4.4-dev Pending

User tests: Successful: Unsuccessful:

avatar richard67
richard67
20 Dec 2023

Pull Request for Issue #42489 (follow-up).

Summary of Changes

With my PR #42489 which just has been merged I have added information about not fulfilled PHP and database requirements to the "No updates" view of the Joomla Update component in case if an update has been found but the environment doesn't fulfil the mentioned requirements for that update.

I've done it like I've seen it elsewhere with a <br> tag in language strings to get all text better readable.

But as mentioned by @brianteeman in that PR, html tags should be avoided in language strings.

This PR here now changes that by removing the <br> tag from the new language strings added with PR #42489 as well as from the previously existing language string which had been added with PR #42103 once and then modified with my mentioned PR, and it changes the PHP code to prepare the content so that it adds these <br> tags.

Testing Instructions

Same as for PR #42489 , except that this time the actual and the expected result is the same, i.e. there should not be any visual difference without and with the PR applied, the <br> tags are still where they should be.

Or just do a code review and make sure that the language strings modified with this PR here are only used by the PHP code modified with this PR here and nowhere else, and that the result regarding the <br> tags will be the same as before.

Actual result BEFORE applying this Pull Request

When the PHP version requirement is not met, an additional sentence shows that, telling the current and the required version.

When the database version requirement is not met, an additional sentence shows that, telling the database type and the current and required versions.

Sentences are separated by <br> tags.

Expected result AFTER applying this Pull Request

Same as actual, no change. But now the <br> tags are added in PHP and are not at the end of language strings.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar richard67 richard67 - open - 20 Dec 2023
avatar richard67 richard67 - change - 20 Dec 2023
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 20 Dec 2023
Category Administration com_joomlaupdate Language & Strings
avatar brianteeman
brianteeman - comment - 20 Dec 2023

LGTM by codereview

avatar richard67
richard67 - comment - 20 Dec 2023

LGTM by codereview

@brianteeman Could you mark a test result in the issue tracker?

avatar brianteeman brianteeman - test_item - 20 Dec 2023 - Tested successfully
avatar brianteeman
brianteeman - comment - 20 Dec 2023

I have tested this item ✅ successfully on f38a0b5


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42550.

avatar dautrich dautrich - test_item - 20 Dec 2023 - Tested successfully
avatar dautrich
dautrich - comment - 20 Dec 2023

I have tested this item ✅ successfully on f38a0b5

I have done a code review. The br-tags have been removed from the language strings and inserted in the PHP code.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42550.

avatar richard67
richard67 - comment - 20 Dec 2023

Thanks all for testing/reviews.

avatar richard67 richard67 - change - 20 Dec 2023
Status Pending Ready to Commit
Labels Added: Language Change PR-4.4-dev
avatar richard67
richard67 - comment - 20 Dec 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42550.

avatar laoneo laoneo - change - 20 Dec 2023
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-12-20 15:52:26
Closed_By laoneo
Labels Added: RTC
avatar laoneo laoneo - close - 20 Dec 2023
avatar laoneo laoneo - merge - 20 Dec 2023
avatar laoneo
laoneo - comment - 20 Dec 2023

Thanks!

Add a Comment

Login with GitHub to post a comment