Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#42542] - [4.4] Load administrator language for article modal

PR-4.4-dev Pending

User tests: Successful: Unsuccessful:

avatar heelc29
heelc29
18 Dec 2023

Summary of Changes

load administrator language file when "administrator content" is loaded like in com_contact

joomla-cms/components/com_contact/src/Dispatcher/Dispatcher.php

Lines 36 to 44 in 8958389

if ($this->input->get('view') === 'contacts' && $this->input->get('layout') === 'modal') {
if (!$this->app->getIdentity()->authorise('core.create', 'com_contact')) {
$this->app->enqueueMessage(Text::_('JERROR_ALERTNOAUTHOR'), 'warning');
return;
}
$this->app->getLanguage()->load('com_contact', JPATH_ADMINISTRATOR);
}

Testing Instructions

open modal for articles in frontend (no articles are present)
image

Actual result BEFORE applying this Pull Request

untranslated strings
image

Expected result AFTER applying this Pull Request

image

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed
  • No documentation changes for manual.joomla.org needed
avatar heelc29 heelc29 - open - 18 Dec 2023
avatar heelc29 heelc29 - change - 18 Dec 2023
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 18 Dec 2023
Category ⇒ Front End com_content
avatar brianteeman
brianteeman - comment - 18 Dec 2023

Unable to replicate the reported problem

avatar heelc29
heelc29 - comment - 18 Dec 2023

Unable to replicate the reported problem

open modal for articles in frontend

avatar brianteeman
brianteeman - comment - 18 Dec 2023

Thanks for the clarification.
tested successfully.

avatar alikon alikon - test_item - 18 Dec 2023 - Tested successfully
avatar alikon
alikon - comment - 18 Dec 2023

I have tested this item ✅ successfully on 39ed9e8

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42542.

avatar Quy Quy - alter_testresult - 18 Dec 2023 - brianteeman: Tested successfully
avatar Quy Quy - change - 18 Dec 2023
Status Pending ⇒ Ready to Commit
Labels Added: PR-4.4-dev
avatar Quy
Quy - comment - 18 Dec 2023

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42542.

avatar MacJoom MacJoom - test_item - 20 Dec 2023 - Tested successfully
avatar MacJoom
MacJoom - comment - 20 Dec 2023

@heelc29 - thanks for the PR - can you update the branch? - drone still seems to run on the 5.0 branch...

avatar heelc29
heelc29 - comment - 20 Dec 2023

@heelc29 - thanks for the PR - can you update the branch? - drone still seems to run on the 5.0 branch...

Sure

avatar heelc29 heelc29 - change - 20 Dec 2023
Labels Added: RTC
avatar joomla-cms-bot joomla-cms-bot - change - 31 Dec 2023
Category Front End com_content ⇒ Front End com_contact com_content
avatar richard67
richard67 - comment - 2 Jan 2024

@laoneo GitHub still shows that there are changes requested due to your review #42542 (review) . But to me it reads as if it has been resolved. Could you either approve the changes on GitHub or dismiss your review? Either the one or the other way should remove that red "Changes requested" shown at the bottom of this PR.

avatar laoneo
laoneo - comment - 10 Jan 2024

@heelc29 why did you put the language loading into the Dispatcher and not the controller? The Dispatcher shouldn't have input dependent logic, this is more the responsibility of the controller.

avatar heelc29
heelc29 - comment - 11 Jan 2024

@heelc29 why did you put the language loading into the Dispatcher and not the controller? The Dispatcher shouldn't have input dependent logic, this is more the responsibility of the controller.

@laoneo You requested me to override the load language function: #42542 (comment)

avatar laoneo
laoneo - comment - 11 Jan 2024

Because the changes were in the wrong function and without input checking.

avatar laoneo
laoneo - comment - 17 Jan 2024

Removed here the milestone as I'm not happy with the latest commit. If input checks are done, then it needs to be moved to the controller.

avatar laoneo laoneo - change - 17 Jan 2024
Status Ready to Commit ⇒ Pending
avatar laoneo
laoneo - comment - 17 Jan 2024

Back to pending

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42542.

avatar laoneo laoneo - change - 17 Jan 2024
Labels Removed: RTC
avatar HLeithner HLeithner - change - 24 Apr 2024
Title
…
[4.x] Load administrator language for article modal
[4.4] Load administrator language for article modal
avatar HLeithner HLeithner - edited - 24 Apr 2024

Add a Comment

Login with GitHub to post a comment