Joomla! Issue Tracker | Joomla! CMS #42542 - [5.2] Load administrator language for article modal

PR-4.4-dev

Pending
Medium
Build: 5.0-dev
# 42542
Diff
heelc29:4.4/site/lang-article-modal

Pending

Pending continuous-integration/drone/pr Build is pending Details

User tests: Successful: Unsuccessful:

heelc29
18 Dec 2023

Summary of Changes

load administrator language file when "administrator content" is loaded like in com_contact

joomla-cms/components/com_contact/src/Dispatcher/Dispatcher.php

Lines 36 to 44 in 8958389

    
           if ($this->input->get('view') === 'contacts' && $this->input->get('layout') === 'modal') { 
        
               if (!$this->app->getIdentity()->authorise('core.create', 'com_contact')) { 
        
                   $this->app->enqueueMessage(Text::_('JERROR_ALERTNOAUTHOR'), 'warning'); 
        
                   return; 
        
               } 
        
               $this->app->getLanguage()->load('com_contact', JPATH_ADMINISTRATOR); 
        
           }

Testing Instructions

open modal for articles in frontend (no articles are present)

Actual result BEFORE applying this Pull Request

untranslated strings

Expected result AFTER applying this Pull Request

Link to documentations

Please select:

No documentation changes for docs.joomla.org needed
No documentation changes for manual.joomla.org needed

39ed9e8 18 Dec 2023

[4.x] Load administrator language for article modal

heelc29 - open - 18 Dec 2023

heelc29 - change - 18 Dec 2023

Status

New

⇒

Pending

joomla-cms-bot - change - 18 Dec 2023

Category

⇒

Front End com_content

brianteeman - comment - 18 Dec 2023

~~Unable to replicate the reported problem~~

heelc29 - comment - 18 Dec 2023

Unable to replicate the reported problem

open modal for articles in frontend

brianteeman - comment - 18 Dec 2023

Thanks for the clarification.
tested successfully.

alikon - test_item - 18 Dec 2023 - Tested successfully

alikon - comment - 18 Dec 2023

I have tested this item ✅ successfully on 39ed9e8

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42542.}

Quy - alter_testresult - 18 Dec 2023 - brianteeman: Tested successfully

Quy - change - 18 Dec 2023

Status	Pending	⇒	Ready to Commit
Labels	Added: PR-4.4-dev

Quy - comment - 18 Dec 2023

RTC

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42542.}

MacJoom - test_item - 20 Dec 2023 - Tested successfully

MacJoom - comment - 20 Dec 2023

@heelc29 - thanks for the PR - can you update the branch? - drone still seems to run on the 5.0 branch...

heelc29 - comment - 20 Dec 2023

@heelc29 - thanks for the PR - can you update the branch? - drone still seems to run on the 5.0 branch...

Sure

25108e7 20 Dec 2023

Merge branch '4.4-dev' into 4.4/site/lang-article-modal

heelc29 - change - 20 Dec 2023

Labels

Added: RTC

f688cd6 31 Dec 2023

Merge branch '4.4-dev' into 4.4/site/lang-article-modal

328c0a9 31 Dec 2023

override loadLanguage function

joomla-cms-bot - change - 31 Dec 2023

Category

Front End com_content

⇒

Front End com_contact com_content

d24b4d9 31 Dec 2023

docs order

bd5bd9a 2 Jan 2024

Merge branch '4.4-dev' into 4.4/site/lang-article-modal

richard67 - comment - 2 Jan 2024

@laoneo GitHub still shows that there are changes requested due to your review #42542 (review) . But to me it reads as if it has been resolved. Could you either approve the changes on GitHub or dismiss your review? Either the one or the other way should remove that red "Changes requested" shown at the bottom of this PR.

45dcb5c 10 Jan 2024

Merge branch '4.4-dev' into 4.4/site/lang-article-modal

laoneo - comment - 10 Jan 2024

@heelc29 why did you put the language loading into the Dispatcher and not the controller? The Dispatcher shouldn't have input dependent logic, this is more the responsibility of the controller.

heelc29 - comment - 11 Jan 2024

@heelc29 why did you put the language loading into the Dispatcher and not the controller? The Dispatcher shouldn't have input dependent logic, this is more the responsibility of the controller.

@laoneo You requested me to override the load language function: #42542 (comment)

laoneo - comment - 11 Jan 2024

Because the changes were in the wrong function and without input checking.

laoneo - comment - 17 Jan 2024

Removed here the milestone as I'm not happy with the latest commit. If input checks are done, then it needs to be moved to the controller.

laoneo - change - 17 Jan 2024

Status

Ready to Commit

⇒

Pending

laoneo - comment - 17 Jan 2024

Back to pending

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42542.}

2b54e0a 17 Jan 2024

Merge branch '4.4-dev' into 4.4/site/lang-article-modal

laoneo - change - 17 Jan 2024

Labels

Removed: RTC

HLeithner - change - 24 Apr 2024

Title

…

[4.x] Load administrator language for article modal

[4.4] Load administrator language for article modal

HLeithner - edited - 24 Apr 2024

HLeithner - comment - 15 Nov 2024

This pull request has been automatically rebased to 5.2-dev.

HLeithner - change - 15 Nov 2024

Title

…

[~~4.4~~] Load administrator language for article modal

[5.2] Load administrator language for article modal

HLeithner - edited - 15 Nov 2024

Add a Comment

Older
Newer

Joomla! Issue Tracker - CMS

[#42542] - [5.2] Load administrator language for article modal

Summary of Changes

Testing Instructions

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Link to documentations

Add a Comment

	if ($this->input->get('view') === 'contacts' && $this->input->get('layout') === 'modal') {
	if (!$this->app->getIdentity()->authorise('core.create', 'com_contact')) {
	$this->app->enqueueMessage(Text::_('JERROR_ALERTNOAUTHOR'), 'warning');

	return;
	}

	$this->app->getLanguage()->load('com_contact', JPATH_ADMINISTRATOR);
	}