Feature Language Change PR-5.3-dev Pending

User tests: Successful: Unsuccessful:

avatar alikon
alikon
16 Dec 2023

Summary of Changes

Add task execution history view

Testing Instructions

apply pr
run the sql script 5.3.0-2024-10-26.sql

Actual result BEFORE applying this Pull Request

N/A

Expected result AFTER applying this Pull Request

click on Execution History button

image

for the task execution history view

image

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

748e2e1 10 Dec 2023 avatar alikon test
bc175dd 10 Dec 2023 avatar alikon test
avatar alikon alikon - open - 16 Dec 2023
avatar alikon alikon - change - 16 Dec 2023
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 16 Dec 2023
Category SQL Administration com_admin Postgresql Language & Strings Installation Front End Plugins
avatar alikon alikon - change - 16 Dec 2023
Labels Added: Language Change PR-5.1-dev
0daffd6 16 Dec 2023 avatar alikon cs
d2a4d1b 16 Dec 2023 avatar alikon cs
0928e53 16 Dec 2023 avatar alikon cs
avatar alikon alikon - change - 17 Dec 2023
Labels Added: Feature
avatar richard67
richard67 - comment - 19 Dec 2023

@alikon I see that the new table has different default values for some columns for MySQL and PostgreSQL. E.g. the "taskname" column has default value empty string for MySQL and no default value for PostgreSQL. That's just one example, there are more. Shouldn't the default values be consistent?

avatar alikon
alikon - comment - 19 Dec 2023

@alikon I see that the new table has different default values for some columns for MySQL and PostgreSQL. E.g. the "taskname" column has default value empty string for MySQL and no default value for PostgreSQL. That's just one example, there are more. Shouldn't the default values be consistent?

silly me, that i've mimed what was already done for the #__scheduler_tasks table

and yes must be consistent.....i'll do something

30dfa7d 19 Dec 2023 avatar alikon old
avatar Quy
Quy - comment - 22 Dec 2023

Move Actions dropdown next to New button to have consistent UI.

avatar alikon
alikon - comment - 23 Dec 2023

Move Actions dropdown next to New button to have consistent UI.

done

avatar Quy
Quy - comment - 23 Dec 2023

Add/update tooltip.

42530-tooltip

avatar Quy
Quy - comment - 23 Dec 2023

Don't capitalize ascending/descending.

42530-sort-by

avatar Quy
Quy - comment - 23 Dec 2023

Task Type and Times Executed not listed in Sort by dropdown.

d511b2c 25 Dec 2023 avatar alikon lang
avatar Quy
Quy - comment - 27 Dec 2023

Enable Delete button only if there are selections.

avatar Quy
Quy - comment - 27 Dec 2023

Selecting Task Type dropdown in Filter Options should not collapse it.

avatar alikon
alikon - comment - 28 Dec 2023

all the reported reviews should be fixed now
thank you @Quy

avatar Quy
Quy - comment - 29 Dec 2023

Edit task should be in edit mode and not display a modal listing the task as it is confusing.

avatar Quy
Quy - comment - 31 Dec 2023

Admin that does not have delete permission.

42530-delete

avatar exlemor exlemor - test_item - 25 Mar 2024 - Tested successfully
avatar exlemor
exlemor - comment - 25 Mar 2024

I have tested this item ✅ successfully on 585ebdd

I tested this successfully. [including Clear History button which works perfectly in the Execution History area].

The only thing I would mention [which may not at all be important], after you press Run Test [on any of them], there is a rather 'slower' than normal refresh of the page (after clicking on the X on the Task window) where all of the icons on the page are squares before loading their appropriate fontawesome equivalents


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42530.

avatar dautrich dautrich - test_item - 29 Mar 2024 - Tested successfully
avatar dautrich
dautrich - comment - 29 Mar 2024

I have tested this item ✅ successfully on 585ebdd


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42530.

avatar Quy Quy - change - 29 Mar 2024
Status Pending Ready to Commit
avatar Quy
Quy - comment - 29 Mar 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42530.

avatar Quy Quy - change - 29 Mar 2024
Labels Added: RTC
avatar alikon
alikon - comment - 11 Apr 2024

no interest

avatar alikon alikon - change - 11 Apr 2024
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2024-04-11 19:13:43
Closed_By alikon
avatar alikon alikon - close - 11 Apr 2024
avatar dautrich
dautrich - comment - 20 Jun 2024

What happened to this PR? Obviously, it's not included in 5.1.1. Will it be part of 5.2?

IMHO it would be a great tool to trace the executions of task plugins in case of any issues. At the moment I have such an issue with a task plugin.

avatar alikon alikon - change - 20 Jun 2024
Status Closed New
Closed_Date 2024-04-11 19:13:43
Closed_By alikon
Labels Removed: RTC
avatar alikon alikon - change - 20 Jun 2024
Status New Pending
avatar alikon alikon - reopen - 20 Jun 2024
avatar Quy
Quy - comment - 26 Jun 2024

This should be rebased for 5.2

avatar rdeutz
rdeutz - comment - 30 Jul 2024

no interest

I like it, maybe was to late for 5.1, rebase to 5.2 would be good

avatar rdeutz rdeutz - change - 30 Jul 2024
Title
[5.1][com_scheduler] task execution history view
[5.2][com_scheduler] task execution history view
avatar rdeutz rdeutz - edited - 30 Jul 2024
avatar alikon alikon - change - 7 Aug 2024
Labels Added: RTC PR-5.2-dev
Removed: PR-5.1-dev
avatar alikon alikon - change - 7 Aug 2024
Labels Removed: RTC
avatar bascherz bascherz - test_item - 24 Aug 2024 - Tested unsuccessfully
avatar bascherz
bascherz - comment - 24 Aug 2024

I have tested this item ? unsuccessfully on 585ebdd

Tested on a fresh installation of 5.2.0-beta1. Note that there was no execution history for any of the default tasks and I did not run SQL script 5.2.0-2023-12-16.sql (Testing Instructions need updating). Got the following error when I clicked the "Execution History" button for each of them. This should be preventable and should not require the table to exist.

An error has occurred.
500 42S02, 1146, Table 'ua887228_scherzingertest.j52test_scheduler_logs' doesn't exist 42S02, 1146, Table 'ua887228_scherzingertest.j52test_scheduler_logs' doesn't exist
Call Stack

Function Location

1 () JROOT/administrator/components/com_scheduler/src/View/Logs/HtmlView.php:97
2 Joomla\Component\Scheduler\Administrator\View\Logs\HtmlView->display() JROOT/libraries/src/MVC/Controller/BaseController.php:697
3 Joomla\CMS\MVC\Controller\BaseController->display() JROOT/administrator/components/com_scheduler/src/Controller/DisplayController.php:59
4 Joomla\Component\Scheduler\Administrator\Controller\DisplayController->display() JROOT/libraries/src/MVC/Controller/BaseController.php:730
5 Joomla\CMS\MVC\Controller\BaseController->execute() JROOT/libraries/src/Dispatcher/ComponentDispatcher.php:143
6 Joomla\CMS\Dispatcher\ComponentDispatcher->dispatch() JROOT/libraries/src/Component/ComponentHelper.php:361
7 Joomla\CMS\Component\ComponentHelper::renderComponent() JROOT/libraries/src/Application/AdministratorApplication.php:150
8 Joomla\CMS\Application\AdministratorApplication->dispatch() JROOT/libraries/src/Application/AdministratorApplication.php:195
9 Joomla\CMS\Application\AdministratorApplication->doExecute() JROOT/libraries/src/Application/CMSApplication.php:306
10 Joomla\CMS\Application\CMSApplication->execute() JROOT/administrator/includes/app.php:58
11 require_once() JROOT/administrator/index.php:32

After executing the SQL script, which creates the missing table, the error was eliminated.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42530.

avatar alikon alikon - change - 25 Aug 2024
The description was changed
avatar alikon alikon - edited - 25 Aug 2024
avatar HLeithner
HLeithner - comment - 2 Sep 2024

This pull request has been automatically rebased to 5.3-dev.

avatar HLeithner HLeithner - change - 2 Sep 2024
Title
[5.2][com_scheduler] task execution history view
[5.3] [com_scheduler] task execution history view
avatar HLeithner HLeithner - edited - 2 Sep 2024
avatar Quy Quy - change - 5 Oct 2024
Labels Added: PR-5.3-dev
Removed: PR-5.2-dev
avatar Quy
Quy - comment - 5 Oct 2024

On mobile, no columns except the Check All Items checkbox.

execution-history

avatar alikon alikon - change - 26 Oct 2024
The description was changed
avatar alikon alikon - edited - 26 Oct 2024
avatar alikon
alikon - comment - 26 Oct 2024

@Quy mobile should be ok

avatar laoneo
laoneo - comment - 12 Nov 2024

In general I would love to see it a bit more inline with the other components. Using the Table class more, etc.

avatar rdeutz
rdeutz - comment - 13 Nov 2024

Some improvements on coding are needed Allon made good suggestions. We target 5.3 for this feature @alikon

Add a Comment

Login with GitHub to post a comment