User tests: Successful: Unsuccessful:
Add task execution history view
apply pr
run the sql script 5.3.0-2024-10-26.sql
N/A
click on Execution History button
for the task execution history view
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
Status | New | ⇒ | Pending |
Category | ⇒ | SQL Administration com_admin Postgresql Language & Strings Installation Front End Plugins |
Labels |
Added:
Language Change
PR-5.1-dev
|
Labels |
Added:
Feature
|
@alikon I see that the new table has different default values for some columns for MySQL and PostgreSQL. E.g. the "taskname" column has default value empty string for MySQL and no default value for PostgreSQL. That's just one example, there are more. Shouldn't the default values be consistent?
silly me, that i've mimed what was already done for the #__scheduler_tasks table
and yes must be consistent.....i'll do something
Move Actions
dropdown next to New
button to have consistent UI.
Move Actions dropdown next to New button to have consistent UI.
done
Task Type
and Times Executed
not listed in Sort by dropdown.
Enable Delete
button only if there are selections.
Selecting Task Type
dropdown in Filter Options
should not collapse it.
Edit task should be in edit mode and not display a modal listing the task as it is confusing.
I have tested this item ✅ successfully on 585ebdd
I tested this successfully. [including Clear History button which works perfectly in the Execution History area].
The only thing I would mention [which may not at all be important], after you press Run Test [on any of them], there is a rather 'slower' than normal refresh of the page (after clicking on the X on the Task window) where all of the icons on the page are squares before loading their appropriate fontawesome equivalents
I have tested this item ✅ successfully on 585ebdd
Status | Pending | ⇒ | Ready to Commit |
RTC
Labels |
Added:
RTC
|
no interest
Status | Ready to Commit | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-04-11 19:13:43 |
Closed_By | ⇒ | alikon |
What happened to this PR? Obviously, it's not included in 5.1.1. Will it be part of 5.2?
IMHO it would be a great tool to trace the executions of task plugins in case of any issues. At the moment I have such an issue with a task plugin.
Status | Closed | ⇒ | New |
Closed_Date | 2024-04-11 19:13:43 | ⇒ | |
Closed_By | alikon | ⇒ | |
Labels |
Removed:
RTC
|
Status | New | ⇒ | Pending |
This should be rebased for 5.2
no interest
I like it, maybe was to late for 5.1, rebase to 5.2 would be good
Title |
|
Labels |
Added:
RTC
PR-5.2-dev
Removed: PR-5.1-dev |
Labels |
Removed:
RTC
|
I have tested this item ? unsuccessfully on 585ebdd
Tested on a fresh installation of 5.2.0-beta1. Note that there was no execution history for any of the default tasks and I did not run SQL script 5.2.0-2023-12-16.sql (Testing Instructions need updating). Got the following error when I clicked the "Execution History" button for each of them. This should be preventable and should not require the table to exist.
An error has occurred.
500 42S02, 1146, Table 'ua887228_scherzingertest.j52test_scheduler_logs' doesn't exist 42S02, 1146, Table 'ua887228_scherzingertest.j52test_scheduler_logs' doesn't exist
Call Stack
1 () JROOT/administrator/components/com_scheduler/src/View/Logs/HtmlView.php:97
2 Joomla\Component\Scheduler\Administrator\View\Logs\HtmlView->display() JROOT/libraries/src/MVC/Controller/BaseController.php:697
3 Joomla\CMS\MVC\Controller\BaseController->display() JROOT/administrator/components/com_scheduler/src/Controller/DisplayController.php:59
4 Joomla\Component\Scheduler\Administrator\Controller\DisplayController->display() JROOT/libraries/src/MVC/Controller/BaseController.php:730
5 Joomla\CMS\MVC\Controller\BaseController->execute() JROOT/libraries/src/Dispatcher/ComponentDispatcher.php:143
6 Joomla\CMS\Dispatcher\ComponentDispatcher->dispatch() JROOT/libraries/src/Component/ComponentHelper.php:361
7 Joomla\CMS\Component\ComponentHelper::renderComponent() JROOT/libraries/src/Application/AdministratorApplication.php:150
8 Joomla\CMS\Application\AdministratorApplication->dispatch() JROOT/libraries/src/Application/AdministratorApplication.php:195
9 Joomla\CMS\Application\AdministratorApplication->doExecute() JROOT/libraries/src/Application/CMSApplication.php:306
10 Joomla\CMS\Application\CMSApplication->execute() JROOT/administrator/includes/app.php:58
11 require_once() JROOT/administrator/index.php:32
After executing the SQL script, which creates the missing table, the error was eliminated.
This pull request has been automatically rebased to 5.3-dev.
Title |
|
Labels |
Added:
PR-5.3-dev
Removed: PR-5.2-dev |
In general I would love to see it a bit more inline with the other components. Using the Table class more, etc.
@alikon I see that the new table has different default values for some columns for MySQL and PostgreSQL. E.g. the "taskname" column has default value empty string for MySQL and no default value for PostgreSQL. That's just one example, there are more. Shouldn't the default values be consistent?