[#42527] - [5.1] Generic doc icon
- Fixed in Code Base
- 28 Dec 2023
- Medium
- Build: 5.1-dev
- # 42527
- Diff
- brianteeman:icon-doc
User tests: Successful: Unsuccessful:
Replaces the pdf icon used in media manager with a more generic doc icon as this is applied to a variety of doc types.
To test
Use one of the prebuilt packages for this PR and check to see that the icon used in media manager for any doc type is no longer a pdf icon.
Changing the icon to a specific one for each type of doc is beyond the scope of this PR
Pull Request for Issue #42518
Before
After
.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Repository NPM Change |
| Labels |
Added:
NPM Resource Changed
PR-5.1-dev
|
||
| Category | Repository NPM Change | ⇒ | Administration com_media NPM Change Repository |
updating branch to see if it will trigger the downloads to be created
@brianteeman #36723 has more icons
but that is closed and as stated
Changing the icon to a specific one for each type of doc is beyond the scope of this PR
The NPM Package (under Download) is not available.
@ChristineWk You can find the downloads here: https://artifacts.joomla.org/drone/joomla/joomla-cms/5.1-dev/42527/downloads/72301/ . Currently there is something broken with updating the links to these downloads on GitHub.
@richard67
Thank you. Hv installed your download with relevant custom update server.
Can this be called successful? see 2nd picture (.doc)
Can this be called successful? see 2nd picture (.doc)
@ChristineWk Not sure now and no time to check. @brianteeman Do you know why she gets the "No preview" icon for the 2nd case .doc?
- did it show the pdf icon before?
- is .doc an allowed file type?
did it show the pdf icon before?
sorry, I'm not sure
- is .doc an allowed file type?
Yes
An essential part of testing is to replicate the before scenario. As you can see in both my before and after screenshots both show the doc file with first a pdf and then a generic icon your test is not successful for some reason
I have tested this item ✅ successfully on 7873ca8
Tested with document types PDF, TXT, DOCX, XLSX
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42527.
I have tested this item ✅ successfully on 7873ca8
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42527.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42527.
| Labels |
Added:
RTC
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-12-28 15:16:56 |
| Closed_By | ⇒ | Razzo1987 |
Thanks!
The NPM Package (under Download) is not available.