? Success

User tests: Successful: Unsuccessful:

avatar bembelimen
bembelimen
9 Sep 2014

If you have a custom installer adapter, the name and the description of the custom elements will not translated. After the patch there is a small "hook" which allows translations.

avatar bembelimen bembelimen - open - 9 Sep 2014
avatar jissues-bot jissues-bot - change - 9 Sep 2014
Labels Added: ?
avatar brianteeman brianteeman - change - 22 Sep 2014
Category Installation Multilanguage
avatar infograf768
infograf768 - comment - 26 Oct 2014

Moving the package further down is all you need?

avatar bembelimen
bembelimen - comment - 26 Oct 2014

Yes and no.

The moving of the package syntax is a side effect. The idea is:

  • every extension (regardsless of the type) has a element name
  • some types (like files, plugins, templates) has a special syntax (file_xxx, plg_xxx, ...)
  • now I added as fallback, that (if no known type is available) the method takes the element name and try to load the "element.sys.ini" (thats the new "default:")
  • it happened that the package makes it the same way, so I "merged" this two handlings to "default + package"

To Test, you can activate the language debug. After that, just rename an existing extension in the database to a unknown type (e.g. com_ajax type from "component" to "foobar")

  • Without patch the type is ignored
  • With patch joomla tries to load JROOT/language/en-GB/en-GB.com_ajax.sys.ini

Of course this file does not exists (because com_ajax is a component) but if someone creates an own installer, he could put his translation file to this place and the type will be translated

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4252.

avatar chmst chmst - test_item - 3 Jan 2015 - Tested successfully
avatar Hackwar
Hackwar - comment - 4 Jan 2015

@test My name is Hannes, and I approve of this PR. :wink:

avatar Hackwar Hackwar - test_item - 4 Jan 2015 - Tested successfully
avatar jacxx
jacxx - comment - 4 Jan 2015

@test, I've tested it and it works. Jacxx :)

avatar zero-24 zero-24 - change - 5 Jan 2015
Status Pending Ready to Commit
avatar zero-24
zero-24 - comment - 5 Jan 2015

Moving to RTC.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4252.

avatar brianteeman brianteeman - change - 14 Jan 2015
Labels Added: ?
avatar roland-d roland-d - close - 16 Jan 2015
avatar roland-d roland-d - change - 16 Jan 2015
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2015-01-16 21:34:39

Add a Comment

Login with GitHub to post a comment