[#42498] - [5.2] mod_tags_similar: fix of missing core_images field
- Pending
- Medium
- Build: 4.4-dev
- # 42498
- Diff
- lorenzods:4.4-dev
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Adding (back) a missing field to the TagsSimilarHelper::getList method
Somehow this field removed over time from resultset, however it's a pretty useful and an easy, non-breaking change.
when showing com_content items based on tags
Testing Instructions
call TagsSimilarHelper::getList
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Resultset will also contain "core_images" field beside "core_params"
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Modules Front End |
Does the same change have to be made to mod_tags_popular?
As i see, mod_tags_popular uses a different query structure, more focused on the tag itself, leaving core content behind.
It could be done though, but IMHO it would require much more effort than this two-liner low hanging fruit.
| Labels |
Added:
PR-4.4-dev
|
||
| Title |
|
||||||
call TagsSimilarHelper::getList
@lorenzods can you give more information how to test?
This pull request has been automatically rebased to 5.2-dev.
| Title |
|
||||||
Does the same change have to be made to mod_tags_popular?