PR-4.4-dev Pending

User tests: Successful: Unsuccessful:

avatar laoneo
laoneo
6 Dec 2023

Summary of Changes

The logout via a menu item should route the redirect to logout task. This error happens on one of my production site but not on a fresh Joomla. So it is probably a configuration issue. Neverthless, all controller actions in this class are routing the requests, so should the menu logout as well.

Testing Instructions

  • Create a logout menu item
  • Log in on the front end
  • Click on the logout menu item
  • Additionally this can also be tested with the htaccess redirect

Actual result BEFORE applying this Pull Request

Logout doesn't work on some sites.

Expected result AFTER applying this Pull Request

Logout through a menu item works direct.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar laoneo laoneo - open - 6 Dec 2023
avatar laoneo laoneo - change - 6 Dec 2023
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 6 Dec 2023
Category Front End com_users
avatar brianteeman
brianteeman - comment - 6 Dec 2023

See #37763

avatar laoneo laoneo - change - 14 Dec 2023
Labels Added: PR-4.4-dev
avatar laoneo
laoneo - comment - 14 Dec 2023

Thanks @brianteeman for the reference. Can you give it a test? So we can ship with the next release.

avatar brianteeman brianteeman - test_item - 19 Dec 2023 - Tested unsuccessfully
avatar brianteeman
brianteeman - comment - 19 Dec 2023

I have tested this item ? unsuccessfully on 501ae72


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42473.

avatar brianteeman
brianteeman - comment - 19 Dec 2023

Sorry for the delay in responding - I had to set up a j4 dev again

Using the detailed test instructions that I wrote in #37763

Before this PR I can no longer replicate the issue in that pr so it must have been solved elsewhere and I have closed it.

With this PR both tests for logging out with the menu item FAIL

Warning
The security token did not match. The request was cancelled to prevent any security breach. Please try again.

avatar laoneo
laoneo - comment - 19 Dec 2023

Can you test again by clearing the cookies first. This error comes mostly from the situation where the session has expired before doing the action.

avatar brianteeman
brianteeman - comment - 19 Dec 2023

That was done at the time. Here is a recording

menu

avatar laoneo
laoneo - comment - 10 Jan 2024

@brianteeman found the issue, can you test again?

avatar brianteeman
brianteeman - comment - 10 Jan 2024

Sorry for the delay in responding - I had to set up a j4 dev again

Using the detailed test instructions that I wrote in #37763

Before this PR I can no longer replicate the issue in that pr so it must have been solved elsewhere and I have closed it.

With this PR both tests for logging out with the menu item FAIL

Warning
The security token did not match. The request was cancelled to prevent any security breach. Please try again.

Repeated the tests.
Still can't replicate the original error
Still can confirm the new error with the earlier version of this pr
Applied the current version of this pr and got no errors

avatar laoneo
laoneo - comment - 11 Jan 2024

Thanks for the test, I could also only reproduce the issue on one of my sites I'm maintaining.

avatar sandewt
sandewt - comment - 11 Jan 2024

Thanks for the test, I could also only reproduce the issue on one of my sites I'm maintaining.

Does the error also occur when you add a new logout menu item to that site?

avatar laoneo
laoneo - comment - 11 Jan 2024

It happens only then.

avatar laoneo
laoneo - comment - 15 Jan 2024

No message, it just doesn't log out.

avatar sandewt
sandewt - comment - 15 Jan 2024

No message, it just doesn't log out.

I remember having the same issue with a site in the past. I can no longer reproduce it now.

avatar MacJoom MacJoom - change - 17 Jan 2024
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2024-01-17 11:47:56
Closed_By MacJoom
avatar MacJoom MacJoom - close - 17 Jan 2024
avatar MacJoom MacJoom - merge - 17 Jan 2024

Add a Comment

Login with GitHub to post a comment