[#42467] - [4.4] Set permission for add-module-to-dashboard button
- Fixed in Code Base
- 27 Jun 2024
- Medium
- Build: 4.4-dev
- # 42467
- Diff
- chmst:cpanel-button-addmodules-permission
User tests: Successful: Unsuccessful:
Pull Request for Issue #41624 .
PR #37268 set wrong permission for the "Add module to dahboard" Button on cpanel.
This was caused because a user had a special use case - descibed in #37267
Summary of Changes
This PR sets the permission back to core.manage on com_modules.
Therefore the issue #37267 is unresolved again.
This special use case needs an other solution. Maybe an override of cpanel.
Testing Instructions
You need a user in usergroup manager. Login as manager - you see the button "Add Module to the dashboard".
Activate.
An Error message is displayed.
Apply the patch - no button for usergroup "manager".
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_cpanel |
Users in group "manager"" are not allowed to work on com_modules. log in as manager and the Menu (content) is:
If the user now activates the button and has not the permission, it gives an error.
| Labels |
Added:
PR-4.4-dev
|
||
I have tested this item ✅ successfully on 2eef018
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42467.
I have tested this item ? unsuccessfully on 2eef018
With this PR at this point all users in the usergroup "Administrator"
see not the "Add Module to the dashboard" button.
No button for usergroup "Administrator" only for "Super Users".
Alternative i have test it with:
<?php if (($user->authorise('core.admin', 'com_modules')) and ($user->authorise('core.create', 'com_modules'))) : ?>
This works for me as aspected.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42467.
| Labels |
Added:
bug
|
||
I have tested this item ✅ successfully on 39a1c85
Works as aspected.
@chmst delete from summary at least this part: "This PR sets the permission back to core.manage on com_modules."
or alternatively change it to: This PR sets the permission back to core.manage on com_modules.
@carlitorweb : Now we need a second test.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42467.
I have tested this item ✅ successfully on 39a1c85
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42467.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42467.
| Labels |
Added:
RTC
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-06-27 09:55:44 |
| Closed_By | ⇒ | MacJoom |
Thank you!
Could you explain what the problem is as it is not clear from your post