[#42461] - [6.x] Use Dialog for Article links, when "modal option" is selected
- Fixed in Code Base
- 5 Mar 2024
- Medium
- Build: 5.1-dev
- # 42461
- Diff
- Fedik:popup-artcile-links
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Success continuous-integration/drone/pr Build is passing Details
User tests: Successful: Unsuccessful:
Summary of Changes
Use Dialog for Artcile links, when "modal option" is selected.
And new feature: Allow to show inline content in the popup.
Testing Instructions
Add a couple links to the Article,
First link: any regular URL.
Second link: #my-popup-target.
Also add to the article content, following html:
<div class="hidden">
<div id="my-popup-target">
<p class="p-3">Lorem ipsum dolor sit amet, cu vis velit signiferumque, eos no possim mollis facilisi.</p>
</div>
</div>For both links select option: show in modal.
Got to article view, and click these links.
Actual result BEFORE applying this Pull Request
First link works in BS Modal:
Second link does nothing.
Expected result AFTER applying this Pull Request
First link works with Joomla Dialog:
Second link works with Joomla Dialog:
Link to documentations
Please select:
- Documentation link for docs.joomla.org:
- No documentation changes for docs.joomla.org needed
- Pull Request link for manual.joomla.org: TBD
- No documentation changes for manual.joomla.org needed
References:
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_content |
| Labels |
Added:
Feature
PR-5.1-dev
|
||
| Category | Front End com_content | ⇒ | Front End com_content Templates (site) |
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42461.
Thank you @Fedik for this nice work!
A direct change of the modal option for the links in article could lead to broken styles and functions in the frontend for some users in conjunction with a Cassiopeia child template, for example.
If a template uses the bootstrap modal events with custom javascript to perform another action when opening or closing, this will unexpectedly stop working. Similarly, custom styles for the modals have to be rewritten from the users and custom css for this purpose will unexpectedly not work anymore.
Perhaps another select option for the new dialog would be a variant to prevent this.
And the deprecation of the BS modal in the frontend for the article links could be the long-term solution.
What do you think about this?
Would be glad to hear further opinions as well.
I can do another option, it is not a problem for me.
But I have seen that current modal option looks bad anyway.
What other thinks? :)
On second thought, another "modal" option will be very confusing, we can probably close it and keep BS here, or rebase to 6-dev
On second thought, another "modal" option will be very confusing
That's exactly what bothers me a little. But I think the new dialog looks much better by default even without adjusting the css. And can be used out of the box with a template that ships no bootstrap. Tricky :) I will try if I can get a few more opinions on this.
| Labels |
Added:
PR-6.0-dev
Removed: PR-5.1-dev |
||
| Category | Front End com_content Templates (site) | ⇒ | Front End com_content |
| Title |
|
||||||
| Status | Ready to Commit | ⇒ | Pending |
Can you please make the requested change, so that we can test this during PBF? Then we can already merge this into 6.0.
| Labels |
Added:
Updates Requested
PBF
|
||
I have tested this item ✅ successfully on b1872ff
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42461.
I have tested this item ✅ successfully on b1872ff
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42461.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42461.
How can this have been tested with 6.x
@brianteeman the pr was made against the 6.0-dev branch. This is the branch where we commit all the changes which should go into 6.0.
| Labels |
Added:
RTC
Removed: Updates Requested |
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-03-05 13:49:20 |
| Closed_By | ⇒ | laoneo |
I have tested this item ✅ successfully on 7801a6a
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42461.