Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#42454] - [5.1] Use Dialog for ContentHistory field

Feature RTC Small PR-5.1-dev Pending

User tests: Successful: Unsuccessful:

avatar Fedik
Fedik
3 Dec 2023

Summary of Changes

Use Dialog for ContentHistory field

Testing Instructions

Do frontend Content editing.
Click Versions button to open Content history.
Try to use diferent Content history features in this popup.

Actual result BEFORE applying this Pull Request

Works with BS Modal

Expected result AFTER applying this Pull Request

Works with Joomla Dialog

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:
  • No documentation changes for docs.joomla.org needed
  • Pull Request link for manual.joomla.org:
  • No documentation changes for manual.joomla.org needed

References:

avatar Fedik Fedik - open - 3 Dec 2023
avatar Fedik Fedik - change - 3 Dec 2023
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 3 Dec 2023
Category ⇒ Administration com_content com_contenthistory Layout
avatar Fedik Fedik - change - 3 Dec 2023
Title
…
[5.2] Use Dialog for ContentHistory field
[5.1] Use Dialog for ContentHistory field
avatar Fedik Fedik - edited - 3 Dec 2023
avatar Fedik Fedik - change - 3 Dec 2023
The description was changed
avatar Fedik Fedik - edited - 3 Dec 2023
avatar Quy
Quy - comment - 6 Dec 2023

Before PR:
42454-before

After PR, alert needs padding:
42454-after

avatar Fedik Fedik - change - 7 Dec 2023
Labels Added: Feature Small PR-5.1-dev
avatar joomla-cms-bot joomla-cms-bot - change - 7 Dec 2023
Category Administration com_content com_contenthistory Layout ⇒ Layout Front End Templates (site)
avatar Fedik
Fedik - comment - 7 Dec 2023

@Quy please try again

avatar Quy Quy - test_item - 7 Dec 2023 - Tested successfully
avatar Quy
Quy - comment - 7 Dec 2023

I have tested this item ✅ successfully on 05184ea

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42454.

avatar Quy
Quy - comment - 7 Dec 2023

I have tested this item ✅ successfully on 05184ea

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42454.

avatar fgsw fgsw - test_item - 8 Dec 2023 - Tested successfully
avatar fgsw
fgsw - comment - 8 Dec 2023

I have tested this item ✅ successfully on 05184ea

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42454.

avatar Quy Quy - change - 8 Dec 2023
Status Pending ⇒ Ready to Commit
avatar Quy
Quy - comment - 8 Dec 2023

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42454.

avatar LadySolveig LadySolveig - change - 14 Dec 2023
Labels Added: RTC
avatar LadySolveig LadySolveig - close - 15 Dec 2023
avatar LadySolveig LadySolveig - merge - 15 Dec 2023
avatar LadySolveig LadySolveig - change - 15 Dec 2023
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2023-12-15 07:42:16
Closed_By ⇒ LadySolveig
avatar LadySolveig
LadySolveig - comment - 15 Dec 2023

Thank you @Fedik ?
Many thanks also for testing @Quy @fgsw

Add a Comment

Login with GitHub to post a comment