User tests: Successful: Unsuccessful:
Minor styling change on the versions button so all the toolbar button are treated equal.
Link should wrap the button+icon and not have a class btn
Labels |
Added:
?
|
Category | ⇒ | Code style Layout |
Status | Pending | ⇒ | Ready to Commit |
Unfortunately, to my knowledge this is not allowed by the W3 spec.
See http://www.w3.org/TR/html5/text-level-semantics.html#the-a-element
The a element may be wrapped around entire paragraphs, lists, tables, and so forth, even entire sections, so long as there is no interactive content within (e.g. buttons or other links).
Verfified with http://validator.w3.org/check. It gives an error The element button must not appear as a descendant of the a element.
Closing this PR as it will produce invalid markup.
Status | Ready to Commit | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-09-08 18:19:56 |
But in this particular occasion element button is not used for any interaction, it is only for cosmetic reasons.
The problem I face is that styling a link as button will NOT behave the same as an actual button element (on hover there is a text shadow which is obsolete in button element).
There is another way to short this out instead of element a make it button and use on click…
I’ll try that
But in this particular occasion element button is not used for any interaction, it is only for cosmetic reasons.
It still seems to count as interactive element and isn't allowed (and thus probably doesn't work in all browsers).
There is another way to short this out instead of element a make it button and use on click…
That would be consistent with the other buttons. I'm not sure why it wasn't done like this.
Because of the old modal js that needs the rel=“bla-bla” I think it’s tricky
good on @dgt41
@test successfull simple change moving to RTC
This comment was created with the J!Tracker Application at http://issues.joomla.org/.