? Language Change PR-4.4-dev Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
29 Nov 2023

The recent security update has exposed a bug in a language string. You cannot have a " in a comment.

Actual result BEFORE applying this Pull Request

image

Expected result AFTER applying this Pull Request

image

Comment

This will need to be upmerged to j5 AND @tecpromotion will need to notify translators

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar brianteeman brianteeman - open - 29 Nov 2023
avatar brianteeman brianteeman - change - 29 Nov 2023
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 29 Nov 2023
Category Administration Language & Strings
avatar heelc29
heelc29 - comment - 29 Nov 2023

Could you also fix:

  • PLG_FIELDS_IMAGELIST_PARAMS_DIRECTORY_DESC
    image
avatar brianteeman brianteeman - change - 29 Nov 2023
Labels Added: Language Change PR-4.4-dev
avatar heelc29 heelc29 - test_item - 29 Nov 2023 - Tested successfully
avatar heelc29
heelc29 - comment - 29 Nov 2023

I have tested this item ✅ successfully on 8d2e481

image
image


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42425.
avatar brianteeman
brianteeman - comment - 29 Nov 2023

I did a quick grep and can't find any more

avatar Quy Quy - test_item - 29 Nov 2023 - Tested successfully
avatar Quy
Quy - comment - 29 Nov 2023

I have tested this item ✅ successfully on 8d2e481


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42425.

avatar Quy Quy - change - 29 Nov 2023
Status Pending Ready to Commit
avatar Quy
Quy - comment - 29 Nov 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42425.

avatar MacJoom MacJoom - change - 29 Nov 2023
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-11-29 18:31:48
Closed_By MacJoom
Labels Added: ?
avatar MacJoom MacJoom - close - 29 Nov 2023
avatar MacJoom MacJoom - merge - 29 Nov 2023
avatar MacJoom
MacJoom - comment - 29 Nov 2023

Thanks for fix

Add a Comment

Login with GitHub to post a comment