You also need to make the same change in templates\cassiopeia\html\mod_menu

if this pr fix #42368
please close #42368

@alikon It should :)

thx

Before PR:

After PR:

It does look better, however, there is no spacing after the icon which will be an issue for existing sites to update each icon with padding.
@chmst Do you have a suggestion since it is from your PR #34658?

I doubt this will be included in v4.4 since it is not a bug per se. @MacJoom

@Quy
from my point of view, when a Joomla user is setting the
"Menu Item > Link Type > Link Icon class: ..."
he can add what he wants for spacing the icon: a "pe-2" class or "me-2", "p-2" etc.
So, to add a fixed class in the code it is not a must. To leave it empty means more freedom during the setting.
OR
Anyway, it should be a "pe-2" class and, sure, it cannot be "p-2" attribute class.

Changing to pe-2 would be a better option, otherwise, a padding class must be added to each icon which is not obvious to do without a help description to mention this.

Hi guys,
so, What is the decision here ?

What is your decision as you have not replied to my last comment?

Can you fix this, so that we can test this during PBF?

@joomleb i wanted to test this PR but reading above comments by @Quy and @Hackwar stopped me.

This pull request has been automatically rebased to 5.2-dev.