PR-5.1-dev Pending

User tests: Successful: Unsuccessful:

avatar alikon
alikon
26 Nov 2023

Summary of Changes

Allow to edit Update Site location

Testing Instructions

Edit Update Sites item location

Actual result BEFORE applying this Pull Request

N/A

Expected result AFTER applying this Pull Request

you can edit and save the Update Site Location

avatar alikon alikon - open - 26 Nov 2023
avatar alikon alikon - change - 26 Nov 2023
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 26 Nov 2023
Category Administration com_installer
avatar brianteeman
brianteeman - comment - 26 Nov 2023

I might be wrong about this but I thought there was a reason that this is not editable

avatar richard67
richard67 - comment - 26 Nov 2023

See #33460 ... @alikon Do you really think it's good to redo a PR without referring to it?

avatar brianteeman
brianteeman - comment - 26 Nov 2023

knew it was discussed somewhere before. thanks for finding it @richard67

avatar toivo toivo - test_item - 26 Nov 2023 - Tested successfully
avatar toivo
toivo - comment - 26 Nov 2023

I have tested this item ✅ successfully on cc62a50

Tested successfully in Joomla 5.1.0-aloha1-dev in Wampserver 3.3.1 using PHP 8.2.12


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42401.

avatar alikon
alikon - comment - 27 Nov 2023

See #33460 ... @alikon Do you really think it's good to redo a PR without referring to it?

i've forgot about that one, its from May 1, 2021 ?

avatar richard67
richard67 - comment - 27 Nov 2023

See #33460 ... @alikon Do you really think it's good to redo a PR without referring to it?

i've forgot about that one, its from May 1, 2021 ?

I see … well, that can happen. I‘ve set it on the task list of the maintainers team so it will be discussed on Wednesday hopefully.

avatar brianteeman
brianteeman - comment - 27 Nov 2023

The reasons against it then havent changed afaict

avatar rdeutz
rdeutz - comment - 29 Nov 2023

We still don't want this change. It doesn't makes sense to allow edit just to have something to edit. We can add a note field so then we have something to edit, but the location should not be editable.

avatar rdeutz rdeutz - close - 29 Nov 2023
avatar rdeutz rdeutz - change - 29 Nov 2023
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2023-11-29 18:08:25
Closed_By rdeutz
Labels Added: PR-5.1-dev
avatar alikon
alikon - comment - 29 Nov 2023

no problem

Add a Comment

Login with GitHub to post a comment