Feeling Lucky
?
[#4239] - Delete obsolete layout files in favour of JLayoutHelper and make use of JLayoutHelper where possible
- Closed
- 7 Sep 2014
- Medium
- Build: staging
- # 4239
- Diff
- matrikular:staging
- Failure The Travis CI build failed Details
User tests: Successful: Unsuccessful:
A couple of layouts became obsolete when JLayoutHelper was introduced. They either were not used at all or just acted as a proxy to then call JLayoutHelper.
jissues-bot
- | Labels |
Added:
?
|
||
brianteeman
- comment
- 7 Sep 2014
Shouldnt they just be marked as deprecated?
This comment was created with the J!Tracker Application at http://issues.joomla.org/.
Bakual
- comment
- 7 Sep 2014
Agreed with Brian with George.
The change to use the JLayouts directly is fine, but you can't remove the existing view layout files in the tmpl folders or you may break existing templates.
Can you change the PR so you add a deprecate message and tag into those files? Then it should be fine.
matrikular
- comment
- 7 Sep 2014
OK, I'll make a new PR then.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-09-07 22:31:48 |
I agree with all these changes but someone did this a while back but it was rejected because it broke a load of non-core backend templates.... (I think even Hathor at one point - although that's since been fixed)