No Code Attached Yet bug
avatar heelc29
heelc29
21 Nov 2023

Steps to reproduce the issue

disable darkmode
open options of TinyMCE plugin

Expected result

TinyMCE is display with light skin
image

Actual result

TinyMCE is displayed with dark skin
image

Additional comments

behavior change with #42322 @wilsonge

avatar heelc29 heelc29 - open - 21 Nov 2023
avatar joomla-cms-bot joomla-cms-bot - change - 21 Nov 2023
Labels Added: No Code Attached Yet
avatar joomla-cms-bot joomla-cms-bot - labeled - 21 Nov 2023
avatar bembelimen
bembelimen - comment - 21 Nov 2023

Hi @heelc29 ,
did you switch after you called the editor in dark or before you entered the backend?

grafik

avatar brianteeman
brianteeman - comment - 21 Nov 2023

#42322

Unlike the template which will actually flick over immediately once the OS is changed this will not change until the page is next reloaded.

avatar bembelimen
bembelimen - comment - 21 Nov 2023

Ahh, sorry, found it now.

avatar Fedik
Fedik - comment - 22 Nov 2023

That happen because oxide-dark/skin.min.css override oxide/skin.min.css:

$wa->registerAndUseStyle('tinymce.skin', 'media/vendor/tinymce/skins/ui/oxide/skin.min.css')
->registerAndUseStyle('tinymce.skin.dark', 'media/vendor/tinymce/skins/ui/oxide-dark/skin.min.css')

The builder does not use any code to manage tinymce styles, it added directly to document.

avatar Fedik Fedik - change - 22 Nov 2023
Labels Added: bug
avatar Fedik Fedik - labeled - 22 Nov 2023
avatar wilsonge
wilsonge - comment - 22 Nov 2023

Yeah we can revert that line I guess. I'd forgotten totally about the tinymce builder. It's not tinymce in anyway - just custom divs and styling to mimic it. So unless we conditionally load the css files in javascript and break CSP we're kinda screwed whatever happens I guess (maybe we can template override - but seems like kinda overkill?)

avatar Fedik Fedik - close - 23 Nov 2023
avatar Fedik
Fedik - comment - 23 Nov 2023

I have reverted it for now, please test #42392

avatar Fedik Fedik - change - 23 Nov 2023
Status New Closed
Closed_Date 0000-00-00 00:00:00 2023-11-23 09:06:49
Closed_By Fedik
avatar brianteeman
brianteeman - comment - 23 Nov 2023

sorry - i missed that this was the plugin setup page

Add a Comment

Login with GitHub to post a comment