[#4235] - [fix] unable to save assets when updateNulls = true
- Closed
- 16 May 2015
- Medium
- Build: staging
- # 4235
- Diff
- phproberto:asset-alias
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Steps to reproduce the issue
We need a table with $updateNulls set to true on store() method. Let's for example use content articles. Edit file:
libraries/legacy/table/content.php
and modify the store method declaration from:
public function store($updateNulls = false)to:
public function store($updateNulls = true)That will try to update null fields on save. Someone decided that the asset table should inherit it.
Now in backend open any article and click Save.
Expected result
Article & the corresponding asset are saved correctly.
Actual result
Page is reloaded without saving message. What happened internally is that the article was saved but the asset was not.
Pull request testing
After applying the patch on this PR try to save the article again. All should be saved correctly.
Backward compatibility
There is no B/C issue as it ensures that any table extending JTableAsset with an alias field still works.
System information (as much as possible)
Joomla: Latest staging 3.3.x version.
Additional comments
Remember to edit back libraries/legacy/table/content.php !! 
jissues-bot
- | Labels |
Added:
?
|
||
brianteeman
- | Category | ⇒ | Libraries |
Updated 
Let's see what Travis says.
Could you please clarify on how to reproduce the problem?
You say "What happened internally is that the article was saved but the asset was not". How can I check this to see if I have the same issue?
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4235.
After setting the update nulls to true in articles table clicking Save doesn't show the success message.
To test that the article is saved but asset don't change article and permissions. Article modifications are applied even without the success message but permissions don't.
After applying the patch thr success message is shown correctly and article & permissions are saved correctly.
Thanks for the info, going to test later
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4235.
The test was successfull! By the way, before applying the patch, the save&close button didn't work. With the patch, everything was fine!
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4235.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-05-16 12:26:00 |
| Closed_By | ⇒ | phproberto |
Please update this PR to latest staging to solve the unittest issues that travis reports.