? bug PR-4.4-dev Pending

User tests: Successful: Unsuccessful:

avatar laoneo
laoneo
13 Nov 2023

Summary of Changes

The context variable is not correctly declared in the workflow publishing plugin. Additionally it checks for concrete event class as getArguments is only available there and not the interface.

Error is also not reported anymore in drone phan step.

Testing Instructions

  • Enable workflow for Articles
  • Change the state of an article

Actual result BEFORE applying this Pull Request

A warning is printed to the error log that the variable context is not declared.

Expected result AFTER applying this Pull Request

No warning.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar laoneo laoneo - open - 13 Nov 2023
avatar laoneo laoneo - change - 13 Nov 2023
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 13 Nov 2023
Category Front End Plugins
b3d7b0e 13 Nov 2023 avatar laoneo cs
avatar laoneo laoneo - change - 13 Nov 2023
Labels Added: PR-4.4-dev
avatar Quy Quy - test_item - 15 Nov 2023 - Tested successfully
avatar Quy
Quy - comment - 15 Nov 2023

I have tested this item ✅ successfully on 6481ec1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42336.

avatar chmst chmst - test_item - 17 Nov 2023 - Tested successfully
avatar chmst
chmst - comment - 17 Nov 2023

I have tested this item ✅ successfully on 4baa0ec


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42336.

avatar Quy Quy - alter_testresult - 17 Nov 2023 - Quy: Tested successfully
avatar Quy Quy - change - 17 Nov 2023
Status Pending Ready to Commit
avatar Quy
Quy - comment - 17 Nov 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42336.

avatar MacJoom MacJoom - change - 18 Nov 2023
Labels Added: ? bug
avatar MacJoom MacJoom - close - 18 Nov 2023
avatar MacJoom MacJoom - merge - 18 Nov 2023
avatar MacJoom MacJoom - change - 18 Nov 2023
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-11-18 14:05:55
Closed_By MacJoom
Labels Added: ?
Removed: ?

Add a Comment

Login with GitHub to post a comment