Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#42316] - Fix missing archive icon

? bug PR-4.4-dev Pending

User tests: Successful: Unsuccessful:

avatar janschoenherr
janschoenherr
7 Nov 2023

This PR fixes a php warning for archived articles.

Summary of Changes

Add missing icon state.

Testing Instructions

Bring up the article select modal in the Joomla content editor and filter by archived articles. Turn on PHP error_reporting and display the errors.

Actual result BEFORE applying this Pull Request

PHP warning for archived articles and no icon shown.

Expected result AFTER applying this Pull Request

No PHP warning and archive icon shown.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar janschoenherr janschoenherr - open - 7 Nov 2023
avatar janschoenherr janschoenherr - change - 7 Nov 2023
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 7 Nov 2023
Category ⇒ Administration com_content
avatar janschoenherr janschoenherr - change - 7 Nov 2023
The description was changed
avatar janschoenherr janschoenherr - edited - 7 Nov 2023
avatar brianteeman
brianteeman - comment - 7 Nov 2023

image

avatar Quy Quy - test_item - 7 Nov 2023 - Tested successfully
avatar Quy
Quy - comment - 7 Nov 2023

I have tested this item ✅ successfully on f1351a2

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42316.

avatar Quy
Quy - comment - 7 Nov 2023

Create a menu item of Single Article.
In the modal window, filter Status to Archived.

Before PR:
42316-archived-icon-before

After PR:
42316-archived-icon-after

avatar Quy Quy - change - 7 Nov 2023
Labels Added: PR-4.4-dev
avatar viocassel viocassel - test_item - 7 Nov 2023 - Tested successfully
avatar viocassel
viocassel - comment - 7 Nov 2023

I have tested this item ✅ successfully on 076fa0f

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42316.

avatar janschoenherr janschoenherr - change - 7 Nov 2023
The description was changed
avatar janschoenherr janschoenherr - edited - 7 Nov 2023
avatar janschoenherr janschoenherr - edited - 7 Nov 2023
avatar janschoenherr janschoenherr - change - 7 Nov 2023
The description was changed
avatar Quy Quy - alter_testresult - 7 Nov 2023 - Quy: Tested successfully
avatar Quy Quy - change - 7 Nov 2023
Status Pending ⇒ Ready to Commit
avatar Quy
Quy - comment - 7 Nov 2023

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42316.

avatar janschoenherr janschoenherr - change - 8 Nov 2023
Title
…
Fix missing icon archive
Fix missing archive icon
avatar janschoenherr janschoenherr - edited - 8 Nov 2023
avatar MacJoom MacJoom - close - 8 Nov 2023
avatar MacJoom MacJoom - merge - 8 Nov 2023
avatar MacJoom MacJoom - change - 8 Nov 2023
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2023-11-08 17:58:02
Closed_By ⇒ MacJoom
Labels Added: ? bug

Add a Comment

Login with GitHub to post a comment