Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#42299] - [5.1][com_finder] check if finder content plugin is enabled

Feature Language Change Updates Requested PR-5.1-dev Pending

User tests: Successful: Unsuccessful:

avatar alikon
alikon
6 Nov 2023

Pull Request for Issue #42296 .

Summary of Changes

correct the test if finder content plugin is enabled

Testing Instructions

Disable finder plugins, then start indexer

Actual result BEFORE applying this Pull Request

no message about disbled plugin

Expected result AFTER applying this Pull Request

message about disbled plugin

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar alikon alikon - open - 6 Nov 2023
avatar alikon alikon - change - 6 Nov 2023
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 6 Nov 2023
Category ⇒ Administration com_finder
avatar Quy Quy - test_item - 6 Nov 2023 - Tested successfully
avatar Fedik
Fedik - comment - 6 Nov 2023

I am sorry to say, but the fix is wrong.
Checking for plugins/content/finder is needed but you removing it here.

What probably needed to fix #42296 is to do an addittional check, whether at least one plugin is enabled in the finder group.

if (!PluginHelper::getPlugin('finder')) {
 $this->app->enqueueMessage('No Finder plugin found, please enable at least one', 'warning');
}

And this will be a new feature, not a bug fix.

avatar alikon
alikon - comment - 6 Nov 2023

no problem, you are right
...i've just forgot about the existence of plugin 'content/finder' too... ?

I'll give it a closer look

avatar alikon alikon - change - 8 Nov 2023
Labels Added: PR-4.4-dev
4c7d253 11 Nov 2023 avatar alikon link
c693df9 11 Nov 2023 avatar alikon lang
avatar joomla-cms-bot joomla-cms-bot - change - 11 Nov 2023
Category Administration com_finder ⇒ Administration com_finder Language & Strings
avatar alikon alikon - change - 11 Nov 2023
Labels Added: Language Change
4334e34 11 Nov 2023 avatar alikon cs
avatar HLeithner
HLeithner - comment - 23 Nov 2023

I don't think that this should go in 4.4 because it's not a bug.

avatar alikon alikon - change - 23 Nov 2023
Labels Added: Feature
avatar joomla-cms-bot joomla-cms-bot - change - 23 Nov 2023
Category Administration com_finder Language & Strings ⇒ Administration com_finder Language & Strings Libraries
avatar alikon alikon - change - 23 Nov 2023
Labels Added: PR-5.1-dev
avatar alikon alikon - change - 23 Nov 2023
Title
…
[4][com_finder] check if finder content plugin is enabled
[5.1][com_finder] check if finder content plugin is enabled
avatar alikon alikon - edited - 23 Nov 2023
avatar alikon alikon - change - 23 Nov 2023
Labels Removed: PR-4.4-dev
avatar joomla-cms-bot joomla-cms-bot - change - 23 Nov 2023
Category Administration com_finder Language & Strings Libraries ⇒ Administration com_finder Language & Strings
avatar alikon
alikon - comment - 23 Nov 2023

switched to 5.1

avatar fgsw fgsw - test_item - 8 Dec 2023 - Tested successfully
avatar fgsw
fgsw - comment - 8 Dec 2023

I have tested this item ✅ successfully on a455afe

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42299.

avatar paternax paternax - test_item - 10 Jan 2024 - Tested successfully
avatar paternax
paternax - comment - 10 Jan 2024

I have tested this item ✅ successfully on a455afe

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42299.

avatar richard67 richard67 - change - 11 Jan 2024
Status Pending ⇒ Ready to Commit
Build 4.4-dev ⇒ 5.1-dev
avatar richard67
richard67 - comment - 11 Jan 2024

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42299.

avatar richard67 richard67 - change - 11 Jan 2024
Status Ready to Commit ⇒ Pending
avatar richard67
richard67 - comment - 11 Jan 2024

Back to pending.

@alikon Could you solve the conflict in file "administrator/components/com_finder/src/Controller/DisplayController.php"?

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42299.

avatar Fedik
Fedik - comment - 13 Jan 2024

@alikon the original code has been changed, and has been moved from controller to the layout, please see #42447.
Please sync your changes with it.

avatar ufuk-avcu ufuk-avcu - test_item - 24 Feb 2024 - Tested successfully
avatar ufuk-avcu
ufuk-avcu - comment - 24 Feb 2024

I have tested this item ✅ successfully on 273a98d

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42299.

avatar nielsnuebel nielsnuebel - test_item - 24 Feb 2024 - Tested successfully
avatar nielsnuebel
nielsnuebel - comment - 24 Feb 2024

I have tested this item ✅ successfully on 273a98d

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42299.

avatar richard67 richard67 - change - 24 Feb 2024
Status Pending ⇒ Ready to Commit
avatar richard67
richard67 - comment - 24 Feb 2024

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42299.

avatar crimle crimle - test_item - 24 Feb 2024 - Tested unsuccessfully
avatar crimle
crimle - comment - 24 Feb 2024

I have tested this item ? unsuccessfully on 273a98d

Plugin Extension - Finder disabled
Components > Smart Search > Index > Button [Index]
There is no error message

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42299.

avatar richard67
richard67 - comment - 24 Feb 2024

I have tested this item ? unsuccessfully on 273a98dPlugin Extension - Finder disabled Components > Smart Search > Index > Button [Index] There is no error message

@crimle It needs to disable all plugins in the "Finder" group, i.e. all with names like "Finder - ...".

avatar dorisdreher dorisdreher - test_item - 24 Feb 2024 - Tested unsuccessfully
avatar dorisdreher
dorisdreher - comment - 24 Feb 2024

I have tested this item ? unsuccessfully on 273a98d

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42299.

avatar richard67
richard67 - comment - 24 Feb 2024

I have tested this item ? unsuccessfully on 273a98d

@dorisdreher Could you report back what has not worked? Maybe you've disabled the wrong plugins? Check also my previous comment.

avatar crimle
crimle - comment - 24 Feb 2024

I have tested this item ? unsuccessfully on 273a98dPlugin Extension - Finder disabled Components > Smart Search > Index > Button [Index] There is no error message

@crimle It needs to disable all plugins in the "Finder" group, i.e. all with names like "Finder - ...".
There is one plugin only when searching for «finder»

avatar dorisdreher dorisdreher - test_item - 24 Feb 2024 - Tested successfully
avatar dorisdreher
dorisdreher - comment - 24 Feb 2024

I have tested this item ✅ successfully on 273a98d

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42299.

avatar crimle crimle - test_item - 24 Feb 2024 - Tested successfully
avatar crimle
crimle - comment - 24 Feb 2024

I have tested this item ✅ successfully on 273a98d

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42299.

avatar Quy Quy - change - 5 Mar 2024
Status Ready to Commit ⇒ Pending
avatar alikon alikon - change - 11 Apr 2024
Status Pending ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2024-04-11 19:04:03
Closed_By ⇒ alikon
Labels Added: Updates Requested
avatar alikon alikon - close - 11 Apr 2024
avatar brianteeman
brianteeman - comment - 18 Dec 2024

Why was this closed. Looks correct to me.

avatar alikon
alikon - comment - 18 Dec 2024

lack of interest, this pr was started on j4.4
i'll repropose it for 5.3, who knows, maybe more luck
😃

avatar alikon
alikon - comment - 18 Dec 2024

redone #44632

Add a Comment

Login with GitHub to post a comment