[#42285] - [5.0] Filter values of custom field, fix #42259
- Fixed in Code Base
- 7 Nov 2023
- Medium
- Build: 5.0-dev
- # 42285
- Diff
- Fedik:field-filter-value
User tests: Successful: Unsuccessful:
Pull Request for Issue #42259 .
Summary of Changes
Filter field value after onCustomFieldsPrepareField
Testing Instructions
Please follow #42259
Create a Text field,
Save it,
And check the field rendering in the layout override.
Or use dump($this->item->jcfields); to see the field ->value
Actual result BEFORE applying this Pull Request
Value contain an empty space
Expected result AFTER applying this Pull Request
Value is empty
Link to documentations
Please select:
- Documentation link for docs.joomla.org:
- No documentation changes for docs.joomla.org needed
- Pull Request link for manual.joomla.org:
- No documentation changes for manual.joomla.org needed
Reference:
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_fields |
| Title |
|
||||||
| Labels |
Added:
bug
PR-5.0-dev
?
|
||
No Problem using Patchtester 4.3.1 in J5.
No Problem using Patchtester 4.3.1 in J5.
Can you confirm what needs to be checked/ticked when I get an access token? Is it just the default that the link from the Patchtester checks? I've installed it on a brand new installation of J5 on a brand new subdomain on a new database.
I uninstalled it, logged out, logged back in and installed it again. Same result.
All those settings in Joomla are correct. What I meant was, what do I check/tick when I request an authentication token on Github at github.com/settings/tokens? I tried on another test site that had been updated from 4.4.0 to 5.0. Same result. It has public_repo, repo:status selected at the moment.
I have tested this item ✅ successfully on 4143e6b
Thanks Fedir, works as expected
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42285.
@Scrabble96 can you please test this pr, simple use the prebuilt packages from https://artifacts.joomla.org/drone/joomla/joomla-cms/5.0-dev/42285/downloads/71682
@korenevskiy nope, what will hapen when value is '0'?
@korenevskiy nope, what will hapen when value is
'0'?
You right!
I have tested this item ✅ successfully on 4143e6b
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42285.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42285.
| Labels |
Added:
?
Removed: ? |
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-11-07 07:42:12 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
?
Removed: ? |
||
thanks
Do we need this Fix in 4.4 as well?
No because we changed the plugin trigger code in 5.0 which leads to this issue.
ah ok - understand , thanks
@Scrabble96 can you please test this pr, simple use the prebuilt packages from https://artifacts.joomla.org/drone/joomla/joomla-cms/5.0-dev/42285/downloads/71682
Hi @HLeithner - I've just got around to testing this. It works fine. Thank you all for fixing and testing this.
@laoneo please check my previous comment #42285 (comment)
trim also a bad idea, it will remove "white space" value
Thanks for the info
Silly question, perhaps, but can whatever was done to change it from J4.4.0 to J.5.0 just be reversed, rather than adding yet more code?
We have updated old events APi to new ?
The com_patchtester_4.3.1 doesn't seem to work in J5 so I can't test this. The error message message says:
An error has occurred while fetching the data from GitHub.
Error inserting pull request data into the database: Incorrect string value: '\xF0\x9F\xA5\x87 )...' for column
[mydomain]_joomlalatestversion.m2f0c_patchtester_pulls.descriptionat row 13