Feeling Lucky
PR-5.0-dev
[#42260] - Update index.php of Cassiopeia, so that it is easier to use a child of Cassiopeia
- Closed
- 1 Nov 2023
- Medium
- Build: 5.0-dev
- # 42260
- Diff
- astridx:patch-2
User tests: Successful: Unsuccessful:
If I'm not mistaking it's more straightforward to create a child template with this change.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Templates (site) |
| Title |
|
||||||
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-11-01 17:39:09 |
| Closed_By | ⇒ | astridx | |
| Labels |
Added:
PR-5.0-dev
|
||
astridx
- comment
- 1 Nov 2023
This breaks the cascade, ie if the file
x.cssdoesn't exist in the child and it exists in the parent then load it from there. I haven't tested but I think the code here should be$wa->registerAndUseStyle($assetColorName, 'global/' . $paramsColorName . '.css');(maybe it needs an attribute
['relative' => true]to work correctly, but it should be relative path so the cascade is not broken)
Oops, you're right. I hadn't considered that not all child templates overwrite all SCSS/CSS data.
We should keep things consistent which are the same in index.php, error.php and maybe also component.php and offline.php. I am almost sure that the code changed here does not only exist in index.php but also in some of the other mentioned files.