? PR-4.4-dev Pending

User tests: Successful: Unsuccessful:

avatar OctavianC
OctavianC
30 Oct 2023

Pull Request for Issue #42252 .

Summary of Changes

Use MVCFactory to create the Table so that userFactory is attached

Testing Instructions

See issue #42252

Actual result BEFORE applying this Pull Request

UserFactory not set in Joomla\Component\Users\Administrator\Table\MfaTable

Expected result AFTER applying this Pull Request

No errors when logging in

Votes

# of Users Experiencing Issue
1/1
Average Importance Score
5.00

avatar OctavianC OctavianC - open - 30 Oct 2023
avatar OctavianC OctavianC - change - 30 Oct 2023
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 30 Oct 2023
Category Libraries
avatar richard67
richard67 - comment - 30 Oct 2023

@OctavianC Could you remove the obsolete use statement use Joomla\Component\Users\Administrator\Table\MfaTable; from the top of the modified file? Currently PHPCS check fails in drone due to the check for unused use statements. Thanks in advance.

avatar OctavianC OctavianC - change - 30 Oct 2023
Labels Added: PR-4.4-dev
avatar agnamr
agnamr - comment - 30 Oct 2023

I have just updated my website from 3.10.12 to 4.4. I have the error mentioned in this thread. When will a fix be available to the general user - is there a file I can update my installation with?
Thanks for your help.
Mary

avatar richard67
richard67 - comment - 30 Oct 2023

I have just updated my website from 3.10.12 to 4.4. I have the error mentioned in this thread. When will a fix be available to the general user - is there a file I can update my installation with? Thanks for your help. Mary

@agnamr The fix can be found here in this PR in the changed files list (one file only).

You can download the changed file "MultiFactorAuthenticationHandler.php" from here https://raw.githubusercontent.com/joomla/joomla-cms/868aa76de29bf4b9ab77e554a3d58af4c8b0d61c/libraries/src/Application/MultiFactorAuthenticationHandler.php and save it in folder "libraries/src/Application". You might have to change the file type in the download dialog of your browser from text to any file to be able to save the file with the original name "MultiFactorAuthenticationHandler.php".

The fix here will be merged into the code when it has 2 successful human tests, and if that happens soon, the fix will be in the next release 4.4.1 (and also in 5.0.1).

You can help with that: If you have downloaded the changed file anyway because you want to fix the issue on your site, and if that works for you, that is already one of the 2 required successful human tests. In this case please go to the pull request in the issue tracker here https://issues.joomla.org/tracker/joomla-cms/42253 , use the blue "Test this" button at the top left corner, select your test result (hopefully "success") and finally submit. The we know you have tested the fix with success and the test will be properly counted.

avatar agnamr
agnamr - comment - 30 Oct 2023

Thanks Richard, I will try it out and report back - I now have another problem signing onto my admin site as I messed around with enabling the authentication plugins and since I didn't already have an MFA method set up I am locked out.
Really appreciate the help.
Mary

From: Richard Fath @.>
Sent: Tuesday, October 31, 2023 8:53 AM
To: joomla/joomla-cms @.
>
Cc: agnamr @.>; Mention @.>
Subject: Re: [joomla/joomla-cms] Fix multi-factor migration when updating from J3 to J4 (PR #42253)

I have just updated my website from 3.10.12 to 4.4. I have the error mentioned in this thread. When will a fix be available to the general user - is there a file I can update my installation with? Thanks for your help. Mary

@agnamrhttps://github.com/agnamr The fix can be found here in this PR in the changed files listhttps://github.com/joomla/joomla-cms/pull/42253/files (one file only).

You can download the changed file "MultiFactorAuthenticationHandler.php" from here https://raw.githubusercontent.com/joomla/joomla-cms/868aa76de29bf4b9ab77e554a3d58af4c8b0d61c/libraries/src/Application/MultiFactorAuthenticationHandler.php and save it in folder "libraries/src/Application". You might have to change the file type in the download dialog of your browser from text to any file to be able to save the file with the original name "MultiFactorAuthenticationHandler.php".

The fix here will be merged into the code when it has 2 successful human tests, and if that happens soon, the fix will be in the next release 4.4.1 (and also in 5.0.1).

You can help with that: If you have downloaded the changed file anyway because you want to fix the issue on your site, and if that works for you, that is already one of the 2 required successful human tests. In this case please go to the pull request in the issue tracker here https://issues.joomla.org/tracker/joomla-cms/42253 , use the blue "Test this" button at the top left corner, select your test result (hopefully "success") and finally submit. The we know you have tested the fix with success and the test will be properly counted.

Reply to this email directly, view it on GitHub#42253 (comment), or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACNGXV2DBFCG6KHIIQLG22DYCAAQPAVCNFSM6AAAAAA6WBIV4SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBVHEZTINBRGI.
You are receiving this because you were mentioned.Message ID: @.***>

avatar jjnxpct
jjnxpct - comment - 2 Nov 2023

I had the same issue on one of our sites and this fix worked for me. Thanks!

avatar richard67
richard67 - comment - 2 Nov 2023

I had the same issue on one of our sites and this fix worked for me. Thanks!

@jjnxpct If that was a successful test, could you go to this PR in the issue tracker here https://issues.joomla.org/tracker/joomla-cms/42253 , use the blue "Test this" button at the top left corner, select your test result (success) and finally submit, so that your test result is properly counted? You know, each PR needs 2 successful tests by human testers to get accepted. Thanks in advance.

avatar jjnxpct jjnxpct - test_item - 2 Nov 2023 - Tested successfully
avatar jjnxpct
jjnxpct - comment - 2 Nov 2023

I have tested this item ✅ successfully on 57cf84f

This worked for me!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42253.

avatar jjnxpct
jjnxpct - comment - 2 Nov 2023
avatar roland-d roland-d - test_item - 5 Nov 2023 - Tested successfully
avatar roland-d
roland-d - comment - 5 Nov 2023

I have tested this item ✅ successfully on 57cf84f

The error was shown after update from J3 to J4. After applying the patch I was able to login.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42253.

avatar Quy Quy - change - 5 Nov 2023
Status Pending Ready to Commit
avatar Quy
Quy - comment - 5 Nov 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42253.

avatar Quy Quy - change - 5 Nov 2023
Labels Added: ?
avatar MacJoom MacJoom - change - 5 Nov 2023
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-11-05 14:47:01
Closed_By MacJoom
Labels Added: ?
Removed: ?
avatar MacJoom MacJoom - close - 5 Nov 2023
avatar MacJoom MacJoom - merge - 5 Nov 2023

Add a Comment

Login with GitHub to post a comment