User tests: Successful: Unsuccessful:
Pull Request for Issue #33432 .
After an exchange of ideas with JXT and due to inactivity on the previous PR about this topic, we decided to create a new PR and use the "file-circle-minus" as delete icon.
Apply the patch, run nmp run build:css
and go to System -> Manage ->Extensions or System -> Update -> Update Sites
The actions "delete", "disable" and "uninstall" have the same icon
System -> Manage ->Extensions
System -> Update -> Update Sites
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
Status | New | ⇒ | Pending |
Category | ⇒ | Repository NPM Change |
file-circle-xmark ..would be possible
Because the trash can in Joomla context means you can get the things out of the trash again. And delete and uninstall are permanent removal. We had this discussion already 1000x ....
@drmenzelit last comment here, since the trash can icon can be used for permanent/statefull delete the problem is not the icon but the UX and the missing dialog that should popup whenever a delete action leads to a permanent delete (ie informing the user that the action is not reversible and if they want to proceed). So, it's not the icon the problem but the way Joomla handles the action (expecting users to distinguish a reversible from an non reversible action from a single icon, increasing complexity, cognitive load, etc for no reason).
My 2c anyways
No personal offenses, my actions are only a way to protect myself, I have no nerves to discuss further two years about an icon. I will close this PR an reopen the issue until some team / release manager / whoever find a consensus.
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-10-30 11:17:09 |
Closed_By | ⇒ | drmenzelit | |
Labels |
Added:
NPM Resource Changed
PR-5.1-dev
|
Modules can be published again ..
That's not what I posted above, that's published icon, I posted the trash icon in the actions...
My last comment here: If you use the trash action on modules, the module goes into the trash. If you filter by trashed, you can recover the module. As in articles too. When filtered by trashed, you get a new action above to empty the trash with an X icon.
Doesn't look right for me, why a
-
and not anX
?