[#42244] - [5.1] Add Tag Relationship in ContentSerializer.php
- Fixed in Code Base
- 3 Nov 2023
- Medium
- Build: 5.0-dev
- # 42244
- Diff
- alexandreelise:patch-1
User tests: Successful: Unsuccessful:
The work was already done by Joomla Team and other contributors what I did is just to use the TagApiSerializerTrait in ContentSerializer. It should be added everywhere where the tags are supported but to make it simple I added it just to ContentSerializer. Hope it helps. Tested it locally on my setup with Postman and it works.
Pull Request for Issue # .
No issues for this pull request
Summary of Changes
Add the Tag Relationship for ContentSerializer
Testing Instructions
- Apply the patch
- Run this command curl -X GET -H "X-Joomla-Token: YOUR_JOOMLA_API_TOKEN" -H "Accept: application/vnd.api+json" --url "https://example.org/api/index.php/v1/content/articles"
- It should return a response in JSON:API format containing the tags relationship
Actual result BEFORE applying this Pull Request
The tag relationship does not appear when doing a GET request on /api/index.php/v1/content/articles
Expected result AFTER applying this Pull Request
The tag relationship appears successfully alongside the other relationships like category and created_by
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
| Labels |
Added:
PR-5.0-dev
|
||
if it's also an issue in 4.4 it have to be recreated against 4.4 branch and upmerged later. can you please do this @alexandreelise ?
if it's also an issue in 4.4 it have to be recreated against 4.4 branch and upmerged later. can you please do this @alexandreelise ?
Hi @HLeithner what do you mean by upmerged later? I don't have merge permission can you clarify please ?
@alexandreelise Upmerge means later when your PR for 4.4-dev will be done and merged into 4.4-dev by a maintainer, maintainers or release leads later merge that change from 4.4-dev up into 5.0-dev (and 5.1-dev) so that fix will be available with both 4.4.1 and 5.0.1 (if ready in time). Nothing you should worry about, you only need to knw that you should redo this PR for the 4.4-dev branch.
@alexandreelise Upmerge means later when your PR for 4.4-dev will be done and merged into 4.4-dev by a maintainer, maintainers or release leads later merge that change from 4.4-dev up into 5.0-dev (and 5.1-dev) so that fix will be available with both 4.4.1 and 5.0.1 (if ready in time). Nothing you should worry about, you only need to knw that you should redo this PR for the 4.4-dev branch.
Thanks for clarifying @richard67
Hi. Should I update this branch as suggested by GitHub to be aligned with upstream? @richard67
if it's also an issue in 4.4 it have to be recreated against 4.4 branch and upmerged later. can you please do this @alexandreelise ?
@HLeithner PR done same as in 5.0-dev as suggested. #42257
Hi. Should I update this branch as suggested by GitHub to be aligned with upstream? @richard67
@alexandreelise No, you can close this PR here as it is the same as the new PR for 4.4-dev so it doesn't need an extra one for 5.0-dev.
Ok thanks
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-10-31 14:32:46 |
| Closed_By | ⇒ | richard67 | |
| Labels |
Added:
Feature
?
|
||
Hi. Should I update this branch as suggested by GitHub to be aligned with upstream? @richard67
@alexandreelise No, you can close this PR here as it is the same as the new PR for 4.4-dev so it doesn't need an extra one for 5.0-dev.
One more thing. Should my future pull request favor oldest supported joomla cms branch so that other maintainers or release lead can upmerge them easier than to redo this mistake I did today? @richard67
@alexandreelise Bug fixes for bugs which exist in 4.4-dev and 5.0-dev have to be made for the 4.4-dev branch. Bug fixes for bugs which only exist in 5.x have to be made for the 5.0-dev branch. New features have to be made for the 5.1-dev branch.
@alexandreelise Bug fixes for bugs which exist in 4.4-dev and 5.0-dev have to be made for the 4.4-dev branch. Bug fixes for bugs which only exist in 5.x have to be made for the 5.0-dev branch. New features have to be made for the 5.1-dev branch.
Thanks for clarifying. Now I understand the process. Have a delightful day @richard67
| Status | Closed | ⇒ | New |
| Closed_Date | 2023-10-31 14:32:46 | ⇒ | |
| Closed_By | richard67 | ⇒ | |
| Labels |
Added:
?
Removed: ? |
||
| Status | New | ⇒ | Pending |
reopen and rebase explained in #42257 (comment)
| Title |
|
||||||
joomla-cms-bot
- | Category | ⇒ | Libraries Front End Plugins |
| Labels |
Added:
PR-5.1-dev
|
||
| Labels |
Added:
?
Removed: ? |
||
| Category | Libraries Front End Plugins | ⇒ | Front End Plugins |
| Labels |
Added:
?
Removed: ? |
||
| Category | Front End Plugins | ⇒ |
| Labels |
Added:
?
Removed: ? |
||
Many thanks for this very nice PR @alexandreelise !
I'm always happy to help @LadySolveig
| Labels |
Added:
?
Removed: ? |
||
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-11-03 06:31:46 |
| Closed_By | ⇒ | LadySolveig | |
| Labels |
Added:
?
Removed: ? |
||
hurray celebrate! super joomlers around the world! we love joomla!
Someone is ruining the party. We should celebrate! A random contributor contributes to our beloved project joomla. We love joomla. Bye...for now.
Do you mean me who ruins the party?
I did not say that the pr is wrong. Only that particular line. And CI does not check the doc blocks. They were brought to this good state by many contributors in all these years.
Why was it merged? Here and there are pr's merged where some stuff was wrong and then we fix it afterwards. This is normally no problem and contributors are happy to help. If you can't, I will do it by myself, no problem.
You don't have to thank me, more @LadySolveig which fixed it while some other people where discussing it.
Thx for your feedback @richard67